Repository navigation
Revert "Release 1378.0.0" - #11207
Merged
Merged
Conversation
This reverts commit 873852a.
Merged
1 of 4 tasks
Closed
Naz-Ovh
pushed a commit
to 0x-fork/metamask-core
that referenced
this pull request
Nov 4, 2026
## Explanation Release **1378.0.0**. This PR bumps `@metamask/social-controllers` from `3.14.1` to `3.14.2` (patch) to ship [MetaMask#11209](MetaMask#11209), which passes the realtime feed item's `authorComment` through from the backend instead of deriving it from trade comments. The root monorepo version is bumped to `1378.0.0`, as the release check requires. `1378.0.0` is the next number after `1377.0.0` ([MetaMask#11203](MetaMask#11203)). An earlier `1378.0.0` attempt ([MetaMask#11205](MetaMask#11205)) was reverted in [MetaMask#11207](MetaMask#11207) before anything was published, so there is no `1378.0.0` tag. Packages deliberately left out of this release: - `@metamask/base-controller`, `@metamask/base-data-service`, `@metamask/controller-utils`, `@metamask/messenger`, and `@metamask/profile-sync-controller` are marked `intentionally-skip` in the release spec. `social-controllers` depends on them, but their unreleased changes are test, tooling, and dev-dependency changes with no consumer-facing API or behavior change. - Other packages with unreleased changes on `main` (for example `@metamask/kyc-controller`) are not part of this release. ## References - Ships [MetaMask#11209](MetaMask#11209) - Previous release: [MetaMask#11203](MetaMask#11203) - Reverted attempt: [MetaMask#11205](MetaMask#11205), [MetaMask#11207](MetaMask#11207) ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate (N/A: version bump and changelog only) - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate (N/A) - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them (N/A: no breaking changes) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Version and changelog updates only; consumer-facing behavior was introduced in the earlier MetaMask#11209 merge, not in this diff. > > **Overview** > **Release-only PR** that bumps the monorepo to **`1378.0.0`** and publishes **`@metamask/social-controllers` `3.14.2`**, with no source changes in the diff. > > The **`3.14.2`** changelog records the patch already merged in [MetaMask#11209](MetaMask#11209): realtime feed items now use the backend’s **`authorComment`** (missing stays missing, **`null`** stays **`null`**, present values use the same validation as the REST feed, invalid values drop the item) instead of deriving it from trade comments. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 20e085a. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Cursor <cursoragent@cursor.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Reverts #11205 (
Release 1378.0.0), which was merged before its predecessor Release/1377.0.0 had been released. The release numbering assumed 1377 would land first, so this release has to come offmain.The revert restores:
1378.0.0→1376.0.0@metamask/kyc-controller0.14.0→0.13.0ensureLocalUserSecret(feat(kyc-controller): exposeensureLocalUserSecretfor reducingstartSessionexecution time by precreating the localUserSecret #11099),getDataShares(feat(kyc-controller): add a data-shares lookup #11158) andcurrentStep(fix(kyc-controller): MakeSessionStatus.finalStatus: pendingonly possible after sumsub has been fully submitted again #11094) entries move back under[Unreleased]Nothing was published. The
mainrun for the merge failed on an unrelatedrate-limit-controllertest, so thePublish releasejob was skipped. No tags were created, and npm still lists@metamask/kyc-controllerat0.13.0.References
Checklist
Made with Cursor
Note
Low Risk
Version and changelog-only revert with no code changes; aligns
mainwith unpublished release state.Reviewed by Cursor Bugbot for commit 9311ab8. Bugbot is set up for automated code reviews on this repo. Configure here.