Skip to content

docs(conditions): add per-row anchors to the attributes tables#11994

Open
JulianMaurin wants to merge 1 commit into
devs/JulianMaurin/github-sourced-attributes/split-github-sourced-attributes-their-own-section--200fc09afrom
devs/JulianMaurin/github-sourced-attributes/add-per-row-anchors-attributes-tables--cad884bd
Open

docs(conditions): add per-row anchors to the attributes tables#11994
JulianMaurin wants to merge 1 commit into
devs/JulianMaurin/github-sourced-attributes/split-github-sourced-attributes-their-own-section--200fc09afrom
devs/JulianMaurin/github-sourced-attributes/add-per-row-anchors-attributes-tables--cad884bd

Conversation

@JulianMaurin

Copy link
Copy Markdown
Contributor

Each attribute row carries a stable pull-request-attributes-<key> id and a
hover-revealed # link, so individual attributes are deep-linkable like config
options (e.g. queue-rule-model-allow_inplace_checks). The id scheme reuses
OptionsTable's defToIdPrefix, and the anchor styling mirrors the config-option
pattern: scroll-margin for the sticky nav and a :target highlight.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

Depends-On: #11993

@mergify mergify Bot had a problem deploying to Mergify Merge Protections June 30, 2026 09:13 Failure
@JulianMaurin

JulianMaurin commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

This pull request is part of a Mergify stack:

# Pull Request Link
1 docs(conditions): split GitHub-sourced attributes into their own section #11993
2 docs(conditions): add per-row anchors to the attributes tables #11994 👈

@mergify

mergify Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🔴 3 of 7 protections blocking · waiting on 👀 reviews and 🙋 you

Protection Waiting on
🔴 ⛓️ Depends-On Requirements 🙋 you
🔴 👀 Review Requirements 👀 reviews
🔴 🔎 Reviews 👀 reviews
🟢 🤖 Continuous Integration
🟢 Enforce conventional commit
🟢 📕 PR description
🟢 🚦 Auto-queue

🔴 ⛓️ Depends-On Requirements

Waiting for

This rule is failing.

Requirement based on the presence of Depends-On in the body of the pull request

🔴 👀 Review Requirements

Waiting for

  • #approved-reviews-by >= 2
This rule is failing.
  • any of:
    • #approved-reviews-by >= 2
    • author = dependabot[bot]
    • author = mergify-ci-bot

🔴 🔎 Reviews

Waiting for

  • #review-requested = 0
This rule is failing.
  • #review-requested = 0
  • #changes-requested-reviews-by = 0
  • #review-threads-unresolved = 0

Show 4 satisfied protections

🟢 🤖 Continuous Integration

  • all of:
    • check-success = build
    • check-success = lint
    • check-success = test
    • any of:
      • check-success = test-broken-links
      • label = ignore-broken-links
    • any of:
      • check-success=Cloudflare Pages
      • -head-repo-full-name~=^Mergifyio/

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:

🟢 📕 PR description

  • body ~= (?ms:.{48,})

🟢 🚦 Auto-queue

When all merge protections are satisfied, this pull request will be queued automatically.

@mergify mergify Bot requested a review from a team June 30, 2026 09:15
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/github-sourced-attributes/split-github-sourced-attributes-their-own-section--200fc09a branch from d318936 to 89d432b Compare July 1, 2026 12:27
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/github-sourced-attributes/add-per-row-anchors-attributes-tables--cad884bd branch from 9e41ebb to fe7fec9 Compare July 1, 2026 12:27
@JulianMaurin

JulianMaurin commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Revision history

# Type Changes Reason Date
1 initial 9e41ebb 2026-07-01 12:27 UTC
2 rebase 9e41ebb → fe7fec9 (rebase only) 2026-07-01 12:27 UTC
3 content fe7fec9 → 9cde143 2026-07-01 12:45 UTC

@mergify mergify Bot had a problem deploying to Mergify Merge Protections July 1, 2026 12:28 Failure
Each attribute row carries a stable `pull-request-attributes-<key>` id and a
hover-revealed `#` link, so individual attributes are deep-linkable like config
options (e.g. queue-rule-model-allow_inplace_checks). The id scheme reuses
OptionsTable's defToIdPrefix, and the anchor styling mirrors the config-option
pattern: scroll-margin for the sticky nav and a :target highlight.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: Icad884bdd3c70cb3e90b12300d8e2af3832f7210
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/github-sourced-attributes/add-per-row-anchors-attributes-tables--cad884bd branch from fe7fec9 to 9cde143 Compare July 1, 2026 12:45
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/github-sourced-attributes/split-github-sourced-attributes-their-own-section--200fc09a branch from 89d432b to 42f1b5e Compare July 1, 2026 12:45
@mergify mergify Bot had a problem deploying to Mergify Merge Protections July 1, 2026 12:46 Failure
@JulianMaurin JulianMaurin marked this pull request as ready for review July 1, 2026 12:54
@mergify mergify Bot requested a review from a team July 1, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants