docs(conditions): split GitHub-sourced attributes into their own section#11993
Open
JulianMaurin wants to merge 1 commit into
Conversation
Contributor
Author
|
This pull request is part of a Mergify stack:
|
Contributor
Merge Protections🔴 2 of 6 protections blocking · waiting on 👀 reviews
🔴 👀 Review RequirementsWaiting for
This rule is failing.
🔴 🔎 ReviewsWaiting for
This rule is failing.
Show 4 satisfied protections🟢 🤖 Continuous Integration
🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 📕 PR description
🟢 🚦 Auto-queueWhen all merge protections are satisfied, this pull request will be queued automatically. |
There was a problem hiding this comment.
Pull request overview
This PR updates the conditions documentation to separate pull request attributes into “Mergify” vs “GitHub-sourced (read-only)” sections, and adds a small metadata accessor to let both the Markdown generator and the React table filter attributes by provenance.
Changes:
- Add
getAttributeSource()to readx-mergify-attribute-metadata.sourcefrom schema definitions. - Filter/partition pull request attributes by source in both
schemaToMarkdownand thePullRequestAttributesReact table. - Update
conditions.mdxto render two attribute tables, with tests covering the new filtering behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/util/schemaToMarkdown.ts | Adds source filtering when generating the pull request attributes markdown table and supports <PullRequestAttributesTable source="..."> replacement. |
| src/util/schemaToMarkdown.test.ts | Adds unit tests ensuring default output excludes GitHub-sourced attributes and that source="github" includes only those. |
| src/util/attributeMetadata.ts | Introduces getAttributeSource() to read attribute provenance from schema metadata. |
| src/util/attributeMetadata.test.ts | Adds tests for getAttributeSource() behavior across valid/malformed inputs. |
| src/content/docs/configuration/conditions.mdx | Splits “Attributes List” into Mergify vs GitHub rulesets/branch protection attributes and renders both tables. |
| src/components/Tables/PullRequestAttributes.tsx | Adds optional source prop and filters the rendered attribute set accordingly when not given staticAttributes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JulianMaurin
force-pushed
the
devs/JulianMaurin/github-sourced-attributes/split-github-sourced-attributes-their-own-section--200fc09a
branch
from
d318936 to
89d432b
Compare
Contributor
Author
Revision history
|
Contributor
|
@JulianMaurin this pull request is now in conflict 😩 |
The attributes list now has two subsections under "Attributes List": Mergify attributes and GitHub rulesets and branch protection attributes. The latter holds the attributes carrying x-mergify-attribute-metadata.source = "github" — read-only values Mergify loads from GitHub that cannot be set in the configuration. A getAttributeSource() accessor reads the schema metadata; both render paths (the PullRequestAttributes React table and the schemaToMarkdown generator) partition on it through an optional source filter. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Change-Id: I200fc09a8c36b3c3ec357b69ef44157257abe3c8
JulianMaurin
force-pushed
the
devs/JulianMaurin/github-sourced-attributes/split-github-sourced-attributes-their-own-section--200fc09a
branch
from
89d432b to
42f1b5e
Compare
kozlek
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attributes list now has two subsections under "Attributes List": Mergify
attributes and GitHub rulesets and branch protection attributes. The latter
holds the attributes carrying x-mergify-attribute-metadata.source = "github" —
read-only values Mergify loads from GitHub that cannot be set in the
configuration.
A getAttributeSource() accessor reads the schema metadata; both render paths
(the PullRequestAttributes React table and the schemaToMarkdown generator)
partition on it through an optional source filter.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com