Skip to content

fix(popupbox): close popup when toggle button is clicked while open #4082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
corvinsz wants to merge 2 commits into
base: master
Choose a base branch
from
+30 −1
Open

fix(popupbox): close popup when toggle button is clicked while open #4082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c375e7c
test(popupbox): verify popup closes when toggle button is clicked
corvinsz Aug 14, 2026
8541a9b
fix(popupbox): close popup when toggle button is clicked while open
corvinsz Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/MaterialDesignThemes.Wpf/PopupBox.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -833,7 +833,7 @@ protected override void OnMouseLeftButtonUp(MouseButtonEventArgs e)

private void ToggleButtonOnPreviewMouseLeftButtonUp(object? sender, MouseButtonEventArgs mouseButtonEventArgs)
{
if (PopupMode == PopupBoxPopupMode.Click || !IsPopupOpen) return;
if (!IsPopupOpen) return;

if (ToggleCheckedContent != null)
{
Expand Down
29 changes: 29 additions & 0 deletions tests/MaterialDesignThemes.UITests/WPF/PopupBoxes/PopupBoxTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,33 @@ await Wait.For(async () =>
await Assert.That(await border.GetBackgroundColor()).IsEqualTo(Colors.Red);
});
}

[Test]
[Description("https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/issues/2280")]
public async Task PopupBox_WhenInOpenedState_ClosesWhenClicked()
{
//Arrange
IVisualElement<PopupBox> popupBox = await LoadXaml<PopupBox>("""
<materialDesign:PopupBox Style="{StaticResource MaterialDesignMultiFloatingActionPopupBox}" IsPopupOpen="True">
<StackPanel>
<Button Content="1" />
<Button Content="2" />
<Button Content="3" />
</StackPanel>
</materialDesign:PopupBox>
""");
bool isOpen = await popupBox.GetIsPopupOpen();
await Assert.That(isOpen).IsTrue();

//Act
IVisualElement<ToggleButton> toggleButton = await popupBox.GetElement<ToggleButton>("/ToggleButton");
await toggleButton.LeftClick();

//Assert
await Wait.For(async () =>
{
isOpen = await popupBox.GetIsPopupOpen();
await Assert.That(isOpen).IsFalse();
});
}
}
Loading