fix(popupbox): close popup when toggle button is clicked while open - #4082
Open
corvinsz wants to merge 2 commits into
Open
fix(popupbox): close popup when toggle button is clicked while open#4082corvinsz wants to merge 2 commits into
corvinsz wants to merge 2 commits into
Conversation
Keboo
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2280
The OP pointed out 3 things:
As @Keboo mentioned, this is by design.
That's what this PR is about.
The fix was just to remove a condition for an early exit in the
ToggleButtonOnPreviewMouseLeftButtonUp()method.I don't see the reason for an early exit in the
PopupBoxPopupMode.Clickmode. I guess this is just old code added 11 years ago. 9c8d873Already fixed in #3843