Skip to content
/ server Public

MDEV-38881: fix for 11.8 #4802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ge65tup wants to merge 1 commit into
base: 11.8
Choose a base branch
from
Open

MDEV-38881: fix for 11.8 #4802

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/mysqldumpslow.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ unless (@ARGV) {
my $defaults = `my_print_defaults --mysqld`;

my $datadir = ($defaults =~ m/--datadir=(.*)/g)[-1];
if (!$datadir or $opt{i}) {
Copy link
Member

@gkodinov gkodinov Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is incorrect. When instance option is specified, It will go read the instances and try to determine data dir even if datadir is specified.

I would support Serg's request: retarget this against main and remove the whole instance thing. The simpler, the better. I doubt anybody is using that.

Failing that please only go to read the instances only if there's an instance option and datadir is not specified.

if ($opt{i}) {
# determine the datadir from the instances section of /etc/my.cnf, if any
my $instances = `my_print_defaults instances`;
die "Can't determine datadir from 'my_print_defaults instances' output: $defaults"
Expand Down