Open
Conversation
|
|
gkodinov
added
the
External Contribution
gkodinov
requested changes
Mar 16, 2026
| my $defaults = `my_print_defaults --mysqld`; | ||
|
|
||
| my $datadir = ($defaults =~ m/--datadir=(.*)/g)[-1]; | ||
| if (!$datadir or $opt{i}) { |
Member
There was a problem hiding this comment.
The fix is incorrect. When instance option is specified, It will go read the instances and try to determine data dir even if datadir is specified.
I would support Serg's request: retarget this against main and remove the whole instance thing. The simpler, the better. I doubt anybody is using that.
Failing that please only go to read the instances only if there's an instance option and datadir is not specified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refers to the version 11.8 and fixes MDEV-38881. The related script mysqldumpslow.sh was modified to avoid handling instances for mariadb-dumpslow without -i option. The previous condition if (!$datadir or $opt(i)) was rewritten into if ($opt(i)), while the body of if-statement remained unaffected by its logic. It means calling mariadb-dumpslow would lead to the next branch which requires $slowlog. While instances are not much supported by MariaDB now, this is the smallest conservative fix to keep the original feature.