Skip to content
/ server Public

MDEV-35767: Prevent MTR from overwriting list-like options in test-specific .cnf files #4792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MicheleFilisina wants to merge 1 commit into
base: 10.11
Choose a base branch
from
+30 −0
Open

MDEV-35767: Prevent MTR from overwriting list-like options in test-specific .cnf files #4792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions mysql-test/lib/My/Config.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,14 @@ my %multipart_options=
(
"plugin-load-add" => 1,
"optimizer-switch" => 1,
"replicate-do-table" => 1,
"replicate-ignore-table" => 1,
"replicate-wild-do-table" => 1,
"replicate-wild-ignore-table" => 1,
"replicate-do-db" => 1,
"replicate-ignore-db" => 1,
"binlog-do-db" => 1,
"binlog-ignore-db" => 1,
);


Expand Down
5 changes: 5 additions & 0 deletions mysql-test/main/mysqltest_multi_opt_replicate_do.cnf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
!include include/default_my.cnf
[mysqld]
replicate_do_table=test.t1
Copy link
Member

@gkodinov gkodinov Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really need to prefix these with "test." ? And does it need to be 3 lines? IMHO 2 would do just fine.

Copy link
Member

@gkodinov gkodinov Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please try to keep a single commit. the github PR UI has as "rebase" button: use that if you need to update your branch. Or the equivalent on the command line.

Copy link
Author

@MicheleFilisina MicheleFilisina Mar 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really need to prefix these with "test." ? And does it need to be 3 lines? IMHO 2 would do just fine.

I tested removing the "test." prefix, but i belive it causes the server to crash on startup (it dies after 0.06 seconds). In var/log i get this error: [ERROR] Could not add do table rule 't1'.
It seems the configuration strictly requires the database.table format.

But i'm not sure though, what do you think?

replicate_do_table=test.t2
replicate_do_table=test.t3
6 changes: 6 additions & 0 deletions mysql-test/main/mysqltest_multi_opt_replicate_do.result
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#
# MDEV-35767 MTR Overwrites Test-Specific .cnf File Options On Duplicate Option
#
SELECT @@replicate_do_table;
@@replicate_do_table
test.t3,test.t1,test.t2
11 changes: 11 additions & 0 deletions mysql-test/main/mysqltest_multi_opt_replicate_do.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
#
# Test list parsing for duplicate .cnf option
#

-- source include/not_embedded.inc

--echo #
--echo # MDEV-35767 MTR Overwrites Test-Specific .cnf File Options On Duplicate Option
--echo #

SELECT @@replicate_do_table;
Binary file added storage/connect/JdbcInterface.jar
View file
Open in desktop
Binary file not shown.