MDEV-35767: Prevent MTR from overwriting list-like options in test-specific .cnf files by MicheleFilisina · Pull Request #4792 · MariaDB/server

MicheleFilisina · 2026-03-12T10:50:37Z

Currently, MTR fails to properly concatenate list-like options (such as replicate_do_table) when they are declared on multiple lines inside a '.cnf' file. Because the MTR parser reads .cnf files into a dictionary/hash structure, so duplicate keys simply overwrite the previous ones.

This patch updates 'mysql-test/lib/My/Config.pm' to normalize incoming option names (stripping leading dashes and exchanging underscores for dashes) prior to checking if they require multipart concatenation. If the option is a known list property and already exists, instead of overwriting the previous value MTR will concatenate the new value onto the existing one separated by a comma.

Added a new MTR test suite scenario with multiple 'replicate-do-table' declarations to prove the property correctly via SHOW VARIABLES.

Also i'm a new contributor (and a student) so i'm kinda newbie. Thus even, though i made my best, i'm not sure to have followed all the guidelines and this code might be a bit 'buggy'. So i'd appreciate a thorough review on the code.

CLAassistant · 2026-03-12T10:51:32Z

All committers have signed the CLA.

gkodinov

Thank you for your contribution. This is a preliminary review.

Please have a single commit.
And have it contain a commit message that complies to CODING_STANDARDS.md
Also, please target 10.11 : this is a bug fix.

mysql-test/lib/My/Config.pm

gkodinov · 2026-03-12T12:21:38Z

mysql-test/lib/My/Config.pm

  return $group->options();
 }

+#


you do not need this.

gkodinov · 2026-03-12T12:21:55Z

mysql-test/lib/My/Config.pm

  croak "group '$group_name' does not exist"
    unless defined($group);

-  my $option= $group->option($option_name);


don't change this please

mysql-test/main/cnf_list_parsing.result

gkodinov · 2026-03-12T12:22:47Z

mysql-test/main/list_parsing.result

@@ -0,0 +1,3 @@
+SHOW VARIABLES LIKE 'replicate_do_table';


disable the test for embedded.

mysql-test/lib/My/Config.pm

mikegriffin · 2026-03-12T22:54:51Z

There are a few more multi-value filter names:

BINLOG_DO_DB
BINLOG_IGNORE_DB
REPLICATE_DO_DB
REPLICATE_DO_TABLE
REPLICATE_IGNORE_DB
REPLICATE_IGNORE_TABLE
REPLICATE_REWRITE_DB
REPLICATE_WILD_DO_TABLE
REPLICATE_WILD_IGNORE_TABLE

grooverdan · 2026-03-13T04:57:56Z

mysql-test/main/list_parsing.result

@@ -0,0 +1,3 @@
+SHOW VARIABLES LIKE 'replicate_do_table';
+Variable_name	Value
+replicate_do_table	test.t3,test.t1,test.t2


is the order of these predictable in the server?

Maybe if it isn't, the they can be ordered with this test:

SELECT tbl FROM JSON_TABLE( CONCAT('[', @@replicate_do_table, ']'),] '$[*]' COLUMNS ( tbl VARCHAR(16) PATH '$' ) ) AS jt ORDER BY tbl;

i had the same suspicion

i tried your query and it gave me syntax error.
wouldn't this one be better?

SELECT GROUP_CONCAT(tbl ORDER BY tbl) AS sorted_replicate_do_table FROM JSON_TABLE( CONCAT('["', REPLACE(@@replicate_do_table, ',', '","'), '"]'), '$[*]' COLUMNS ( tbl VARCHAR(255) PATH '$' ) ) AS jt;

that works. I was rough estimating with a numeric example. Thanks for working it out.

the order is important IMHO

MicheleFilisina · 2026-03-13T14:05:30Z

i didn't add a test for each multi-value filter name, but i tested them locally, also, should i open a new pull request to target 10.11?

grooverdan · 2026-03-13T21:42:47Z

i didn't add a test for each multi-value filter name, but i tested them locally, also, should i open a new pull request to target 10.11?

you can rebase your commits to 10.11, squash them up, git force push to the same branch and this PR will updated. Then edit the title of this PR - there's the target branch listed there, change that to 10.11.

gkodinov

Looks much better! Thanks for working on this.
Some polishing suggestions below.

mysql-test/main/list_parsing.test

gkodinov · 2026-03-16T14:05:21Z

mysql-test/main/list_parsing.test

@@ -0,0 +1,8 @@
+--source include/not_embedded.inc
+SELECT GROUP_CONCAT(tbl ORDER BY tbl) AS sorted_replicate_do_table


I do not mind the nice derived table etc, but I'd just do SELECT @@replicate_do_table. The order should be stable.

Oh, I didn't know the order is deterministic. Thanks for the advice 👍.

mysql-test/main/list_parsing.cnf

gkodinov · 2026-03-16T14:07:18Z

mysql-test/main/mysqltest_multi_opt_replicate_do.cnf

+!include include/default_my.cnf
+
+[mysqld.1]
+replicate_do_table=test.t1


Do you really need to prefix these with "test." ? And does it need to be 3 lines? IMHO 2 would do just fine.

Also, please try to keep a single commit. the github PR UI has as "rebase" button: use that if you need to update your branch. Or the equivalent on the command line.

Do you really need to prefix these with "test." ? And does it need to be 3 lines? IMHO 2 would do just fine.

I tested removing the "test." prefix, but i belive it causes the server to crash on startup (it dies after 0.06 seconds). In var/log i get this error: [ERROR] Could not add do table rule 't1'.
It seems the configuration strictly requires the database.table format.

But i'm not sure though, what do you think?

mysql-test/main/list_parsing.cnf

…te Option Add some multi-part options to Config.pm, Add a test case for list parsing in mysqltest_multi_opt_replicate_do

MicheleFilisina · 2026-03-16T22:05:27Z

I was wondering if it would be better to add tests for other multi-options as well?

gkodinov added the External Contribution All PRs from entities outside of MariaDB Foundation, Corporation, Codership agreements. label Mar 12, 2026

gkodinov changed the title ~~Mdev 35767: Prevent MTR from overwriting list-like options in test-specific .cnf files~~ MDEV-35767: Prevent MTR from overwriting list-like options in test-specific .cnf files Mar 12, 2026

gkodinov requested changes Mar 12, 2026

View reviewed changes

MicheleFilisina force-pushed the MDEV-35767-fix branch from 61eb286 to 2186a4f Compare March 12, 2026 16:21

grooverdan reviewed Mar 13, 2026

View reviewed changes

MicheleFilisina force-pushed the MDEV-35767-fix branch from f7be74a to 221ee43 Compare March 13, 2026 13:57

MicheleFilisina closed this Mar 13, 2026

MicheleFilisina reopened this Mar 13, 2026

MicheleFilisina requested a review from gkodinov March 13, 2026 19:55

MicheleFilisina force-pushed the MDEV-35767-fix branch from 546f020 to 2a8012d Compare March 14, 2026 22:13

MicheleFilisina changed the base branch from main to 10.11 March 14, 2026 22:15

gkodinov requested changes Mar 16, 2026

View reviewed changes

MDEV-35767: MTR Overwrites Test-Specific .cnf File Options On Duplica…

b71c4c1

…te Option Add some multi-part options to Config.pm, Add a test case for list parsing in mysqltest_multi_opt_replicate_do

MicheleFilisina force-pushed the MDEV-35767-fix branch from d21e30e to b71c4c1 Compare March 16, 2026 22:01

		@@ -0,0 +1,8 @@
		--source include/not_embedded.inc
		SELECT GROUP_CONCAT(tbl ORDER BY tbl) AS sorted_replicate_do_table

Uh oh!

Conversation

MicheleFilisina commented Mar 12, 2026

Uh oh!

CLAassistant commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gkodinov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mikegriffin commented Mar 12, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MicheleFilisina commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grooverdan commented Mar 13, 2026

Uh oh!

gkodinov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MicheleFilisina Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MicheleFilisina Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MicheleFilisina commented Mar 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

CLAassistant commented Mar 12, 2026 •

edited

Loading

MicheleFilisina commented Mar 13, 2026 •

edited

Loading

MicheleFilisina Mar 16, 2026 •

edited

Loading

MicheleFilisina Mar 16, 2026 •

edited

Loading