Repository navigation
fix(sources): open the AWS disconnect dialog from any source tab - #1723
Merged
Merged
Maple Review Bot / Maple / review
succeeded
Oct 22, 2026 in 27s
Confidence 10/10 · No issues found
🟢 Confidence 10/10 · safe to merge
The dialog moves to the source header that renders on every tab, the card stands down when focused, and a scene test pins both mounts.
no findings · tests covered · risk medium
Moves the AWS disconnect dialog out of the Connection-only card into the source header, so Delete opens it on any tab, with one mount per page. Contained and safe to merge.
awsDisconnectDialogreads the AWS status itself and is exportedactionsEmbedmounts it for a focused AWS source- The AWS card renders it only when unfocused
What was checked
headerActionsrenders on every tab (sources/detail/view.ts:149)clickedDeleteonly opens the dialog for a connection present in the loaded status, so the title keeps its account id (update.ts:374)- The card skips the dialog when
focusIdis set (view-aws.ts:492), so focused pages mount it once
d0725c2 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading