[Makisuo]

Problem

On an AWS source (including one whose stack was never deployed), clicking Delete did nothing unless you were on the Connection tab.

Delete on an AWS source opens the AWS disconnect dialog (so the cleanup script is shown afterwards), but that dialog was only rendered inside the AWS card, which only appears on the Connection tab. On Overview or Settings the dialog was open in the model with nothing mounted.

Fix

• view-aws.ts: awsDisconnectDialog reads the AWS status itself; the card renders it only without a focusId (the integrations page).
• embed.ts: the source header (actionsEmbed) renders it for a focused AWS source, the same way it already renders Google Cloud's removal dialogs. One mount per page.

Test

New scene test in sources/detail/detail.scene.test.ts: Delete on the Overview tab renders the Disconnect AWS account … alertdialog, and the Connection tab renders it exactly once. It fails without the fix. The previous test only asserted disconnectDialog.isOpen on the model, which is why this slipped.

vitest run src/page/sources/detail src/page/integrations (136 passed), web typecheck and oxlint clean.

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[maple-review-bot]

Maple review

🟢 Confidence 10/10 · safe to merge
The dialog moves to the source header that renders on every tab, the card stands down when focused, and a scene test pins both mounts.
_{no findings · tests covered · risk medium}

Moves the AWS disconnect dialog out of the Connection-only card into the source header, so Delete opens it on any tab, with one mount per page. Contained and safe to merge.

• awsDisconnectDialog reads the AWS status itself and is exported
• actionsEmbed mounts it for a focused AWS source
• The AWS card renders it only when unfocused

What was checked

• headerActions renders on every tab (sources/detail/view.ts:149)
• clickedDelete only opens the dialog for a connection present in the loaded status, so the title keeps its account id (update.ts:374)
• The card skips the dialog when focusId is set (view-aws.ts:492), so focused pages mount it once

_{d0725c2 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.}

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 49 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: b46c394c-6c43-49da-9117-268b3e26bdd8

📥 Commits

Reviewing files that changed from the base of the PR and between 137e60c and d0725c2.

📒 Files selected for processing: 3

• apps/web/src/page/integrations/embed.ts
• apps/web/src/page/integrations/view-aws.ts
• apps/web/src/page/sources/detail/detail.scene.test.ts

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}