Skip to content

ci(previews): run the preview e2e in its own job - #1722

Open
Makisuo wants to merge 6 commits into
mainfrom
ci/preview-e2e-own-job
Open

Makisuo wants to merge 6 commits into
mainfrom
ci/preview-e2e-own-job

ci(previews): fetch only the two e2e secrets by name; skip the sync-b…

38b0321
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 23, 2026 in 1m 21s

Confidence 9/10 · No issues found

🟢 Confidence 9/10 · safe to merge
No defects in either diff; the one gap is coverage: the tiered-rule e2e no longer runs on the default preview:web previews.
no findings · tests partial −1 · risk medium

Moves the preview browser e2e out of the deploy job into its own e2e job that loads only two named secrets, gates the sync-dependent alert-rules test on preview:web, and drops continue-on-error. It ran green on this PR, so it is safe to merge.

Fixed since the last review

  • ✅ F3 · Infisical export path is rooted at one step and workspace-relative at the other
What was checked
  • F3's export file is gone: no SECRETS_FILE/filter step remains in .github at the head; both keys use secret-name + export-type: env.
  • Skip rationale holds: the editor resolves ?ruleId= from synced collection rows (apps/web/src/page/alerts/editor/draft.ts:64), absent on preview:web.
  • Chromium cache and the dropped --with-deps mirror ci.yml:272-284, keyed on the e2e engine version.

38b0321 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.