Skip to content

feat(ci): CI analytics over a year, like the rest of Code Review - #1720

Merged
Makisuo merged 3 commits into
ci-rollup/queriesfrom
ci-rollup/range
Oct 23, 2026
Merged

feat(ci): CI analytics over a year, like the rest of Code Review#1720
Makisuo merged 3 commits into
ci-rollup/queriesfrom
ci-rollup/range

test(ci): two months read in daily buckets

26acc9d
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 23, 2026 in 36s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge
Delta since the last review is one test file, and its new cases pin the daily tier, the weekly buckets and the previous-period guard.
no findings · tests covered · risk low

Adds a two-month daily-bucket test, a previous-period retention guard test and a weekly-bucket landing test to CiAnalyticsService. Test-only since the last review; safe to merge.

Fixed since the last review

  • ✅ F1 · New daily bucket tier (32–120 days) has no test
What was checked
  • Daily tier pinned by the 60-day case (CiAnalyticsService.test.ts:130): 6-hour buckets would give 240 bars, not 60
  • Previous-period guard pinned by read counts at a TestClock of END (CiAnalyticsService.test.ts:143)
  • Weekly rows land in distinct epoch-aligned slots; fillSeries in CiAnalyticsService.ts:262 aligns on floor(startTime / bucketMs)

26acc9d · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

View more details on Maple Review Bot