Skip to content

ci: gate CI passed (and the prd deploy) on the ingest Rust and collector Go tests - #1717

Merged
Makisuo merged 3 commits into
mainfrom
ci/gate-ingest-and-collector-tests
Oct 23, 2026
Merged

Makisuo merged 3 commits into
mainfrom
ci/gate-ingest-and-collector-tests

ci: give ingest-rust 30 minutes for a cold cargo cache

cd89814
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 22, 2026 in 24s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge
CI-only change: path filters, job steps and the CI passed needs list line up with what the removed workflows ran, and the timeout concern is now 30 minutes.
no findings · tests not needed · risk medium

Moves the ingest Rust tests and the collector's Go checks into ci.yml as path-gated jobs that CI passed requires, so a red Rust build no longer deploys. Safe to merge.

  • ingest-rust and otel-collector jobs added to ci.yml and required by CI passed
  • ingest-rust gets 30 minutes, persist-credentials: false on both checkouts
  • ingest-bench.yml keeps only the opt-in load benchmark

Fixed since the last review

  • ✅ F1 · ingest-rust has 20 minutes for a job the old one gave 45
What was checked
  • telemetry.rs:7875 includes the scraper fixture; the ingest filter lists it
  • No path filters on on:, so changes and both gates run for every PR
  • deploy-prd.yml:26 gates on the whole CI run conclusion, so skipped jobs cannot block it

cd89814 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.