[Makisuo]

Main's Tests (@maple/backend-3-of-3) lane is red since #1685: all six completeConnect with the installation listed for the user and … cases fail with expected [] to deeply equal [ '/user/memberships/orgs/octo' ].

#1675 made completeConnect require the signed-in initiator; the admin-role cases added in #1685 still pass three arguments, so OAuthState.consume dies on initiator.orgId before any membership request is made. packages/backend excludes *.test.ts from typecheck, so only the test run noticed.

The fix passes INITIATOR, as every other case in the file does.

Verified: GithubConnectService.test.ts 28/28 locally (6 failing before).

🤖 Generated with Claude Code

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[maple-review-bot]

Maple review

🟢 Confidence 10/10 · safe to merge
A one-argument test fix matching the four-arg completeConnect calls already in the file; nothing else changes.
_{no findings · tests covered · risk low}

Passes the missing INITIATOR argument in the single completeConnect call behind the six table-driven admin-role cases, fixing the red backend test lane. Safe to merge.

• The admin-role connect cases now pass INITIATOR to completeConnect

What was checked

• INITIATOR is the file's shared org_test/user_1 fixture (GithubConnectService.test.ts:55)
• Every other completeConnect call in the file already passes the initiator fourth (lines 190, 209, 311, 318)
• One call site covers all six adminCases via the for loop, so nothing else stayed unfixed

_{8a40588 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.}

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 12 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: dff811c9-4104-4747-b745-db4f23d3416a

📥 Commits

Reviewing files that changed from the base of the PR and between 23c97ea and 8a40588.

📒 Files selected for processing: 1

• packages/backend/src/services/integrations/vcs/vendor/github/__tests__/GithubConnectService.test.ts

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}