Skip to content

core: shorten horizon for short consumption forecasts instead of failing #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaStr merged 1 commit into from
Oct 28, 2026
Merged

core: shorten horizon for short consumption forecasts instead of failing #476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/batcontrol/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@
TIME_BETWEEN_EVALUATIONS = EVALUATIONS_EVERY_MINUTES * 60
TIME_BETWEEN_UTILITY_API_CALLS = 900 # 15 Minutes
MIN_FORECAST_HOURS = 1 # Minimum required forecast hours
FORECAST_TOLERANCE = 3 # Acceptable tolerance for forecast hours

CONTROL_SOURCE_API = 'api'
CONTROL_SOURCE_OPTIMIZER = 'optimizer'
Expand Down Expand Up @@ -777,10 +776,9 @@ def _run_once(self):
consumption_forecast = self.fc_consumption.get_forecast(
requested_slots)
if len(consumption_forecast) < requested_slots:
# Accept a shorter forecast horizon if not enough data is
# available
if len(consumption_forecast) < max(
fc_period - FORECAST_TOLERANCE, MIN_FORECAST_HOURS):
# A shorter consumption forecast reduces the forecast horizon,
# like it does for prices and production
if len(consumption_forecast) < MIN_FORECAST_HOURS:
Comment thread
MaStr marked this conversation as resolved.
# Note: string formatting to avoid f-string multiline issues in <=Python3.11
raise RuntimeError(
"Not enough consumption forecast data available, requested %d, got %d" % (
Expand Down
Loading