[MaStr]

Problem

With the Home Assistant consumption forecast the run failed:

RuntimeError: Not enough consumption forecast data available, requested 210, got 191

The HA provider is capped at 48h (MAX_FORECAST_HOURS, 192 slots at 15 min, minus 1 for the shift to the current interval). Price and production forecasts reached ~52.5h. The shortfall was larger than FORECAST_TOLERANCE (3 slots), so the run raised and the inverter fell back to Allow Discharging.

Change

• A consumption forecast shorter than requested now reduces fc_period to the available data, as already done for prices and production.
• Only an empty forecast (fewer than MIN_FORECAST_HOURS) is still an error.
• Remove the now unused FORECAST_TOLERANCE.

Testing

Existing tests pass (tests/batcontrol, web tests and tests needing pytest-mock not run locally). No new test added.

🤖 Generated with Claude Code

[Copilot]

🟡 Changes recommended

An unresolved active finding flags that the broadened reduced-horizon forecast path lacks regression test coverage, leaving the fix unverified.

1 open issue

• Missing test for reduced forecast horizon fallback and empty forecast · New

What changed in this PR

This PR makes batcontrol more resilient when the consumption forecast is shorter than the price/production forecast horizon. Previously, if the Home Assistant consumption provider (capped at 48h) returned fewer slots than the ~52.5h price/production horizon and the shortfall exceeded a fixed FORECAST_TOLERANCE of 3 slots, the control cycle raised RuntimeError and the inverter fell back to Allow Discharging. The change aligns consumption handling with how prices and production are already harmonized: a short forecast simply shortens fc_period rather than aborting the cycle.

Changes:

• A consumption forecast shorter than requested now reduces fc_period to the available data instead of failing.
• Only an effectively empty forecast (len < MIN_FORECAST_HOURS) still raises an error.
• Removes the now-unused FORECAST_TOLERANCE constant.

File	Description
src/​batcontrol/​core.py	Replaces the tolerance-bounded error check with an unconditional horizon reduction for short consumption forecasts, keeps the empty-forecast error branch, and drops the unused FORECAST_TOLERANCE constant.

_{Review effort: Balanced}