-
Notifications
You must be signed in to change notification settings - Fork 0
fix(web): categorize docs nav and stop calling sessions isolated #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f1c2adf
fix(web): categorize docs nav and stop calling sessions isolated
yashranaway 4efb48d
fix(web): keep command directory in sync with COMMANDS.md
yashranaway 721c138
test(web): exercise command directory behavior
SarthakWade 7fe89ff
test(web): verify command discovery in Chromium
SarthakWade 67473c8
Merge remote-tracking branch 'origin/main' into HEAD
SarthakWade 7bb71e1
refactor(web): simplify command filtering
SarthakWade 99af0a8
Merge remote-tracking branch 'origin/main' into HEAD
SarthakWade 1fd28a0
Merge remote-tracking branch 'origin/main' into HEAD
SarthakWade File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| "use client"; | ||
|
|
||
| import { CommandBlock } from "@/components/docs-copy-controls"; | ||
| import { plainText } from "@/lib/markdown"; | ||
| import { useState } from "react"; | ||
|
|
||
| type CommandGroup = { | ||
| title: string; | ||
| id: string; | ||
| description: string; | ||
| usage: string; | ||
| }; | ||
|
|
||
| export function CommandDirectory({ groups }: { groups: CommandGroup[] }) { | ||
| const [query, setQuery] = useState(""); | ||
| const normalized = query.trim().toLowerCase(); | ||
| const visible = normalized | ||
| ? groups.filter((group) => | ||
| `${group.title} ${group.description} ${group.usage}` | ||
| .toLowerCase() | ||
| .includes(normalized), | ||
| ) | ||
| : groups; | ||
|
|
||
| const countLabel = | ||
| visible.length === 0 | ||
| ? `No commands match “${query}”.` | ||
| : `${visible.length} of ${groups.length} groups`; | ||
|
|
||
| return ( | ||
| <> | ||
| <div className="command-filter"> | ||
| <label htmlFor="command-filter">Filter commands</label> | ||
| <input | ||
| id="command-filter" | ||
| type="search" | ||
| value={query} | ||
| onChange={(event) => setQuery(event.target.value)} | ||
| placeholder="visit, inspect, credentials…" | ||
| autoComplete="off" | ||
| spellCheck={false} | ||
| /> | ||
| <p role="status" aria-live="polite"> | ||
| {countLabel} | ||
| </p> | ||
| </div> | ||
| {visible.length > 0 ? ( | ||
| <nav className="docs-toc docs-toc-inline" aria-label="On this page"> | ||
| <p>On this page</p> | ||
| {visible.map((group) => ( | ||
| <a href={`#${group.id}`} key={group.id}> | ||
| {group.title} | ||
| </a> | ||
| ))} | ||
| </nav> | ||
| ) : null} | ||
| {visible.map((group, index) => ( | ||
| <section id={group.id} key={group.id}> | ||
| <p className="docs-label"> | ||
| {String(index + 1).padStart(2, "0")} / {group.title} | ||
| </p> | ||
| <h2>{group.title}</h2> | ||
| <p>{plainText(group.description)}</p> | ||
| <CommandBlock>{group.usage}</CommandBlock> | ||
| </section> | ||
| ))} | ||
| </> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.