fix(web): categorize docs nav and stop calling sessions isolated - #173
fix(web): categorize docs nav and stop calling sessions isolated#173yashranaway wants to merge 1 commit into
Conversation
Docs navigation is now an explicit category catalog instead of slicing the route list. The overview pulls the shared-profile contract from COMMANDS.md. The command reference is filterable from that same source.
dfd4b82 to
f1c2adf
Compare
SarthakWade
left a comment
SarthakWade
left a comment
There was a problem hiding this comment.
This should not merge yet because the Web app does not build and the new command directory has correctness and accessibility gaps.
The exact PR head fails provenance lint and next build because the new shared-session extraction still looks for obsolete wording. After that is corrected, the directory still omits the shipped Credential vault section, leaves table-of-contents links pointing at sections removed by filtering, and does not announce positive result-count changes to assistive technology. Please add focused search, keyboard, responsive, and accessibility coverage as required by issue #159.
GitHub currently reports the PR as mergeable with no conflicts. The Web app required check is failing; the other required checks passed. ESLint, TypeScript, and the dependency audit passed, and I found no dependency vulnerability or secret exposure in this change.
| extractSection(commandReference, "Host lifecycle"), | ||
| ).find( | ||
| (item) => | ||
| item.includes("one browser profile") && item.includes("not an isolation"), |
There was a problem hiding this comment.
[P1] This phrase no longer exists in the authoritative COMMANDS.md text, which now describes shared normal sessions and shipped isolated sessions. sessionModel is therefore undefined and the fail below breaks provenance lint and production prerendering. Match a stable part of the current source contract and add a fixture/assertion that catches source wording drift without making the site unbuildable after a valid docs update.
| <CommandBlock>{group.usage}</CommandBlock> | ||
| </section> | ||
| ))} | ||
| <CommandDirectory groups={commands.groups} /> |
There was a problem hiding this comment.
[P2] commands.groups still contains only lifecycle, navigation, capture, and diagnostics. The authoritative Credential vault section, including auth login and credential commands, is omitted, so this page is not the complete agent surface and those commands cannot be found. Include every shipped command section from COMMANDS.md and derive the displayed count from the same complete set.
| return ( | ||
| <DocsShell | ||
| activePath="/docs/commands" | ||
| sections={commands.groups.map((group) => ({ |
There was a problem hiding this comment.
[P2] This table of contents is built from all groups, but CommandDirectory filters the rendered sections independently. After a query hides a group, its TOC link remains and points to a missing element. The filter state needs to drive both the directory and its section links, or hidden groups must remain valid anchor targets.
| autoComplete="off" | ||
| spellCheck={false} | ||
| /> | ||
| <p> |
There was a problem hiding this comment.
[P2] Positive result-count changes are not announced because this is an ordinary paragraph; only the zero-result branch has status semantics. Give the changing count an appropriate polite live region or role=status, and cover it with an accessibility-focused search test.
2 participants
Summary
Implements #159.
Did not add Settings, Credentials, or SDK pages. Those wait on their contracts.
Closes #159