Skip to content

build: hard-fail configure if asciidoctor is missing #4086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grandixximo wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −9
Open

build: hard-fail configure if asciidoctor is missing #4086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions src/configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1067,16 +1067,19 @@ AC_ARG_ENABLE(build-documentation,
# --enable-build-documentation=html). =html itself warn-and-disables
# only the missing PDF tools; users who want PDF best-effort can pass
# =html and rebuild after installing the missing tools.
if ( test "$BUILD_DOCS" = "yes" ) ; then
AC_PATH_PROG(ASCIIDOCTOR,asciidoctor,"none")
if ( test "none" = "$ASCIIDOCTOR" ) ; then
AC_MSG_WARN([no asciidoctor, documentation cannot be built
install with "sudo apt-get install asciidoctor"])
BUILD_DOCS=no
BUILD_DOCS_PDF=no
BUILD_DOCS_HTML=no
fi
# asciidoctor is required unconditionally: the manpage build rule in
# docs/src/Submakefile invokes it for every halcompile-built manpage
# (5axisgui.1 etc.), independent of --enable-build-documentation.
# Without it `make` later dies with "asciidoctor: command not found"
# in the middle of the build. Hard-fail at configure time instead.
AC_PATH_PROG(ASCIIDOCTOR,asciidoctor,"none")
if ( test "none" = "$ASCIIDOCTOR" ) ; then
AC_MSG_ERROR([no asciidoctor, manpages cannot be built
install with "sudo apt-get install asciidoctor" on Debian / Ubuntu,
"sudo dnf install rubygem-asciidoctor" on Fedora, or "gem install asciidoctor"])
fi

if ( test "$BUILD_DOCS" = "yes" ) ; then
if ( test "$BUILD_DOCS" = "yes" ) ; then
AC_PATH_PROG(GS,gs,"none")
if ( test "none" = "$GS" ) ; then
Expand Down
Loading