build: hard-fail configure if asciidoctor is missing#4086
Open
grandixximo wants to merge 1 commit into
Open
Conversation
The manpage build rule in docs/src/Submakefile invokes asciidoctor for every halcompile-built manpage, independent of --enable-build-documentation. The configure probe for it was nested inside `if BUILD_DOCS = yes`, so a plain `./configure --enable-run-in-place` (no docs opt-in) silently passed and later crashed make with `asciidoctor: command not found` (issue LinuxCNC#4084). Move the probe out of the BUILD_DOCS gate and promote the warning to a hard error pointing at the package name on Debian / Fedora / RubyGems. The PDF / HTML / Rouge probes stay gated since they only matter when --enable-build-documentation was passed.
Contributor
|
In debian/control.top.in you have: Shouldn't you also remove the nodoc tag because halcompile needs it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4084.
The manpage build rule at docs/src/Submakefile:1127 invokes
asciidoctorfor every halcompile-built manpage (5axisgui.1etc.), independent of--enable-build-documentation. The configure probe added by the asciidoctor migration (#4053) was nested insideif BUILD_DOCS = yes, so a plain./configure --enable-run-in-place(no docs opt-in) silently passed andmakelater crashed withasciidoctor: command not found.This PR moves the probe out of the
BUILD_DOCSgate and promotes the warning to a hard error pointing at the package name on Debian / Fedora / RubyGems. The PDF / HTML / Rouge probes stay gated since they only matter when--enable-build-documentationwas passed.Test plan
configure.acedit preserves indentation of every untouched line (blame intact on the GS / RSVG / Rouge probes).asciidoctorinstalled:./configure --enable-run-in-placesucceeds andmake ../docs/man/man1/5axisgui.1builds the manpage.apt remove asciidoctor:./configure --enable-run-in-placeaborts withconfigure: error: no asciidoctor, manpages cannot be built(followed by the per-distro install hint) instead of failing insidemake.