Fix NVCC version check mismatch in test_nvcc131_BugReproducer.h #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated NVCC version threshold from 12.4.99 to 13.1.99 to match the comment stating the bug "Affects versions 12.4 until 13.1". The new logic correctly excludes versions 12.4 through 13.1.x where the bug exists. Co-authored-by: albertandaluz <176801700+albertandaluz@users.noreply.github.com>
Added NVCC_VERSION_12_4_00 macro for consistency and maintainability, replacing the hardcoded 120400 value. Co-authored-by: albertandaluz <176801700+albertandaluz@users.noreply.github.com>
Clarified that versions >= 13.2 will compile (since 13.1.99 is the threshold) Co-authored-by: albertandaluz <176801700+albertandaluz@users.noreply.github.com>
Co-authored-by: albertandaluz <176801700+albertandaluz@users.noreply.github.com>
Removed codeql_checker build artifacts that were accidentally committed and added _codeql_build_dir/ and _codeql_detected_source_root to .gitignore to prevent future accidental commits. Co-authored-by: albertandaluz <176801700+albertandaluz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback on adding CUDA 13 to LTS branch
Fix NVCC version check mismatch in test_nvcc131_BugReproducer.h
Dec 27, 2025
Member
|
Fix the conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version check in
test_nvcc131_BugReproducer.hdidn't align with its comment stating the bug "Affects versions 12.4 until 13.1". The check excluded only versions ≥12.4.99, allowing buggy versions 12.4.0-12.4.98 and all 13.x to compile.Changes
NVCC_VERSION_12_4_99toNVCC_VERSION_12_4_00(lower bound) andNVCC_VERSION_13_1_99(upper bound)version < 12.4.0 || version >= 13.2.0, properly excluding the affected range.gitignoreentries for CodeQL build artifacts (_codeql_build_dir/,_codeql_detected_source_root)✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.