171 add cuda 13 to lts branch #172

albertandaluz · 2025-12-11T17:53:53Z

No description provided.

Copilot

Pull request overview

This PR adds support for CUDA 13.1 to the LTS branch, including workarounds for compiler bugs affecting NVCC versions 12.4 through 13.1. The changes enable the project to build and test with CUDA 13.1 while maintaining backward compatibility with earlier CUDA versions.

Key Changes:

Added conditional compilation guards to work around NVCC 12.4+ compiler bugs that prevent certain constexpr code from compiling
Updated CMake configuration to handle CUDA 13-specific library versions and runtime library modes
Extended CI/CD workflows to include CUDA 13.1 in the test matrix

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
tests/data/test_tuple.h	Added conditional compilation to skip problematic constexpr tests on NVCC 12.4-13.1
tests/cudabug/test_nvcc131_BugReproducer.h	New file documenting and reproducing the NVCC bug affecting versions 12.4-13.1
cmake/tests/add_shared_test_libs.cmake	Added /Zc:preprocessor flag for MSVC to enforce standards-compliant preprocessor
cmake/tests/add_generated_test.cmake	Added /Zc:preprocessor flag for MSVC test targets
cmake/libs/cuda/target_generation.cmake	Added CUDA 13 handling with Hybrid runtime library mode and /Zc:preprocessor flag
cmake/libs/cuda/deploy.cmake	Added CUDA 13 library version mappings (cufft64_12, curand64_10) and x64 subdirectory path
benchmarks/CMakeLists.txt	Added /Zc:preprocessor flag for MSVC benchmark targets
.github/workflows/cmake-windows-amd64.yml	Added CUDA 13.1 with MSVC 14.44 to Windows test matrix
.github/workflows/cmake-linux-arm64.yml	Added conditional CUDACXX export to handle both nvcc and other CUDA compilers
.github/workflows/cmake-linux-amd64.yml	Added CUDA 13.1 configurations and conditional CUDACXX export for nvcc/clang++

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/cudabug/test_nvcc131_BugReproducer.h

cmake/libs/cuda/deploy.cmake

tests/data/test_tuple.h

tests/cudabug/test_nvcc131_BugReproducer.h

cmake/libs/cuda/target_generation.cmake

Copilot · 2025-12-11T17:58:41Z

.github/workflows/cmake-linux-amd64.yml

-        export PATH=/usr/lib/llvm-21/bin/:$PATH  
-        export CUDACXX=/usr/local/cuda-${cpp_compiler[2]}/bin/nvcc
-        cmake -G "Ninja" -B ${{steps.strings.outputs.build-output-dir}} -DCMAKE_CXX_COMPILER="${cpp_compiler[0]}" -DCMAKE_CUDA_COMPILER="${cpp_compiler[1]}"  -DCUDAToolkit_ROOT="/usr/local/cuda-${cpp_compiler[2]}" -DCMAKE_BUILD_TYPE="Release" -S ${{github.workspace}}       
+        export PATH=/home/cudeiro/cmake-4.2.1-linux-x86_64/bin:/usr/lib/llvm-21/bin/:$PATH 


This line appears to have a hardcoded absolute path specific to a particular machine (/home/cudeiro/cmake-4.2.1-linux-x86_64/bin). This will cause failures on other machines or CI runners. Either remove this path addition if cmake is available in the system PATH, or make it configurable via an environment variable or workflow input.

Suggested change

export PATH=/home/cudeiro/cmake-4.2.1-linux-x86_64/bin:/usr/lib/llvm-21/bin/:$PATH

export PATH=/usr/lib/llvm-21/bin/:$PATH

@albertandaluz why do we have those hardcoded paths?

tests/cudabug/test_nvcc131_BugReproducer.h

added ci configurations for cuda 13.1 on windows and linux (x64) pass :/Zc:preprocessor to supress warnings about legacy preprocessor on msvc add compiler preprocvessor guards to skip compilation of test_tuple.h with cuda 12.4 added a reproducer for a nvcc bug found with cuda 12.4 # Conflicts: # .github/workflows/cmake-linux-amd64.yml # .github/workflows/cmake-linux-arm64.yml # .github/workflows/cmake-windows-amd64.yml # cmake/libs/cuda/target_generation.cmake

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 9 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cmake/tests/add_generated_test.cmake

tests/cudabug/test_nvcc131_BugReproducer.h

tests/data/test_tuple.h

tests/cudabug/test_nvcc131_BugReproducer.h

cmake/libs/cuda/deploy.cmake

Copilot · 2025-12-27T11:25:48Z

.github/workflows/cmake-linux-amd64.yml

+        else
+            export CUDACXX="${cpp_compiler[1]}"
+        fi
+        cmake -G "Ninja" -B ${{steps.strings.outputs.build-output-dir}} -DCMAKE_CXX_COMPILER="${cpp_compiler[0]}" -DCMAKE_CUDA_COMPILER=${CUDACXX} -DCUDAToolkit_ROOT="/usr/local/cuda-${cpp_compiler[2]}" -DCMAKE_BUILD_TYPE="Release" -S ${{github.workspace}}       


The CUDACXX variable should be quoted in the cmake command for safety. Change -DCMAKE_CUDA_COMPILER=${CUDACXX} to -DCMAKE_CUDA_COMPILER="${CUDACXX}" to prevent issues if the path contains spaces or special characters.

Suggested change

cmake -G "Ninja" -B ${{steps.strings.outputs.build-output-dir}} -DCMAKE_CXX_COMPILER="${cpp_compiler[0]}" -DCMAKE_CUDA_COMPILER=${CUDACXX} -DCUDAToolkit_ROOT="/usr/local/cuda-${cpp_compiler[2]}" -DCMAKE_BUILD_TYPE="Release" -S ${{github.workspace}}

cmake -G "Ninja" -B ${{steps.strings.outputs.build-output-dir}} -DCMAKE_CXX_COMPILER="${cpp_compiler[0]}" -DCMAKE_CUDA_COMPILER="${CUDACXX}" -DCUDAToolkit_ROOT="/usr/local/cuda-${cpp_compiler[2]}" -DCMAKE_BUILD_TYPE="Release" -S ${{github.workspace}}

@albertandaluz the suggestion seem's reasonable. Can you check it?

Copilot · 2025-12-27T11:52:44Z

@albertandaluz I've opened a new pull request, #176, to work on those changes. Once the pull request is ready, I'll request review from you.

albertandaluz

most suggestion are correct regarding identation. not sure abouth hardcoded paths since we only use a single self host runner for builds

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/data/test_tuple.h

tests/cudabug/test_nvcc131_BugReproducer.h

cmake/libs/cuda/deploy.cmake

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

albertandaluz requested a review from Copilot December 11, 2025 17:54

Copilot started reviewing on behalf of albertandaluz December 11, 2025 17:54 View session

Copilot AI reviewed Dec 11, 2025

View reviewed changes

albertandaluz changed the title ~~171 add cuda 131 to lts branch~~ 171 add cuda 13 to lts branch Dec 12, 2025

albertandaluz added 3 commits December 27, 2025 12:22

use c++17 also for cuda on LTS branch

755bb44

downgrading cuda to 13.0

406553b

Copilot AI review requested due to automatic review settings December 27, 2025 11:22

albertandaluz force-pushed the 171-add-cuda-131-to-lts-branch branch from befc311 to 406553b Compare December 27, 2025 11:22

Copilot started reviewing on behalf of albertandaluz December 27, 2025 11:23 View session

removed cuda 12.9 from windows builds

04fc2cc

Copilot AI reviewed Dec 27, 2025

View reviewed changes

Copilot AI mentioned this pull request Dec 27, 2025

Fix NVCC version check mismatch in test_nvcc131_BugReproducer.h #176

Draft

albertandaluz commented Dec 27, 2025

View reviewed changes

Update tests/cudabug/test_nvcc131_BugReproducer.h

9702c18

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings December 31, 2025 14:09

Update tests/data/test_tuple.h

e6191ce

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started reviewing on behalf of morousg December 31, 2025 14:09 View session

morousg and others added 3 commits December 31, 2025 15:10

Update tests/data/test_tuple.h

ea773bb

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update tests/cudabug/test_nvcc131_BugReproducer.h

1fab4a9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update tests/cudabug/test_nvcc131_BugReproducer.h

e005504

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Dec 31, 2025

View reviewed changes

tests/data/test_tuple.h Show resolved Hide resolved

tests/cudabug/test_nvcc131_BugReproducer.h Show resolved Hide resolved

cmake/libs/cuda/deploy.cmake Show resolved Hide resolved

cmake/libs/cuda/deploy.cmake Show resolved Hide resolved

Update tests/cudabug/test_nvcc131_BugReproducer.h

a5de5c7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings December 31, 2025 14:13

Copilot AI reviewed Dec 31, 2025

View reviewed changes

morousg merged commit 9b8671a into LTS-C++17 Dec 31, 2025
11 checks passed

	export PATH=/home/cudeiro/cmake-4.2.1-linux-x86_64/bin:/usr/lib/llvm-21/bin/:$PATH
	export PATH=/usr/lib/llvm-21/bin/:$PATH

	cmake -G "Ninja" -B ${{steps.strings.outputs.build-output-dir}} -DCMAKE_CXX_COMPILER="${cpp_compiler[0]}" -DCMAKE_CUDA_COMPILER=${CUDACXX} -DCUDAToolkit_ROOT="/usr/local/cuda-${cpp_compiler[2]}" -DCMAKE_BUILD_TYPE="Release" -S ${{github.workspace}}
	cmake -G "Ninja" -B ${{steps.strings.outputs.build-output-dir}} -DCMAKE_CXX_COMPILER="${cpp_compiler[0]}" -DCMAKE_CUDA_COMPILER="${CUDACXX}" -DCUDAToolkit_ROOT="/usr/local/cuda-${cpp_compiler[2]}" -DCMAKE_BUILD_TYPE="Release" -S ${{github.workspace}}

Uh oh!

171 add cuda 13 to lts branch #172

171 add cuda 13 to lts branch #172

Uh oh!

Conversation

albertandaluz commented Dec 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

morousg Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 27, 2025

Choose a reason for hiding this comment

Uh oh!

morousg Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Dec 27, 2025

Uh oh!

albertandaluz left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants