[cristim]

Summary

Part of #109 (go part only). Adds common.HoursPerYear (8760) in pkg/common and replaces the bare 8760 literals with it in azure cache, compute, cosmosdb, database, managedredis, search and synapse, and in gcp computeengine pricing.go (dropping its private copy). Behavior-preserving: no existing test changed.

• Skipped on purpose: gcp cloudsql, cloudstorage and memorystore (open fix(gcp): fail closed on region-less storage SKUs and ambiguous SKU matches #471 edits them) and azure savingsplans (open fix(azure): count savings plans billed to another subscription in the duplicate check #491). Follow-up once those merge.
• Not done here: the ARCH-10: monthlyCostFromConvertibleRI money formula duplicated verbatim, with bare 730/8760 despite named constants [go part] #109 acceptance item for an exported HoursPerMonth; AWS's private hoursPerYear at providers/aws/recommendations/parser_sp.go:~100; gcp cloudstorage averageHoursPerMonth = 8760.0 / 12 (client.go:22, skipped because fix(gcp): fail closed on region-less storage SKUs and ambiguous SKU matches #471 is open); the monthlyCostFromConvertibleRI duplication and its bare 730 live in cloud-commitments-platform, and the GCP billing service ID constants are left for a separate pass.
• No existing shared constant existed (only per-package copies), hence the new one in pkg/common.

Pin note

Commit 1 adds the pkg constant; commit 2 pins azure and gcp go.mod to commit 1 (the go#535 pattern) so GOWORK=off builds. A chore: pin pkg to main follow-up is needed after merge (as #537 did for #535).

Test plan

build, vet, go test -count=1 ./..., golangci-lint for pkg, providers/azure, providers/gcp, each with and without GOWORK=off: all pass. Secrets allowlist 44 PASS.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

• Run on-demand review

_{This review includes 11 billable files and costs up to $2.75.}

• Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 3 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 88 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Repository: LeanerCloud/cloud-commitments-go/.coderabbit.yaml
• Review profile: CHILL
• Plan: Essentials
• Run ID: 76e18690-7377-4737-94c0-025e3d2b2155

📥 Commits

Reviewing files that changed from the base of the PR and between c223501 and e9f38c8.

⛔ Files ignored due to path filters: 2

• providers/azure/go.sum is excluded by !**/*.sum
• providers/gcp/go.sum is excluded by !**/*.sum

📒 Files selected for processing: 11

• pkg/common/hours.go
• providers/azure/go.mod
• providers/azure/services/cache/client.go
• providers/azure/services/compute/client.go
• providers/azure/services/cosmosdb/client.go
• providers/azure/services/database/client.go
• providers/azure/services/managedredis/client.go
• providers/azure/services/search/client.go
• providers/azure/services/synapse/client.go
• providers/gcp/go.mod
• providers/gcp/services/computeengine/pricing.go

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[cristim]

Merge gate verdict (claude-cc-libs)

Every gate holds at head e9f38c8:

• Two independent reviews approve the reviewed head a1598c2. The branch was then updated from main, and the PR diff is byte-identical to the reviewed diff (compared mechanically).
• CI is green on e9f38c8, which is the reviewed change on top of current main.
• 0 unresolved threads; MERGEABLE/CLEAN.

CodeRabbit is waived as a merge gate under the 2026-10-19 decision. Squash-merging.