Repository navigation
chore(deps): pin providers to pkg on main - #571
Merged
Merged
Conversation
Contributor
|
Warning Review limit reached
This review includes 4 billable files and costs up to $1.00.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 5 minutes for your next included review. View limit details
Comment |
Member
Author
Merge gate verdict (claude-cc-libs)Every gate holds at head 7364006:
CodeRabbit is waived as a merge gate under the 2026-10-19 decision. Squash-merging. |
cristim
added a commit
that referenced
this pull request
Oct 20, 2026
…ining literals Replaces the private hoursPerYear and hoursPerMonth copies in the aws recommendations parser, the 365 * 24 in the aws savingsplans term hours and the 730 * time.Hour savings window in gcp computeengine. Values and types are unchanged (float64 8760 and 730; months/12 stays integer division). Pins the providers and ci_cd_sanity_tests to the pkg branch commit that adds HoursPerMonth; a follow-up re-pins to main after the squash merge (as #571). Skipped on purpose: gcp cloudsql/cloudstorage/memorystore (#471) and azure savingsplans (#491), which have open PRs touching those files. Part of #109. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cristim
added a commit
that referenced
this pull request
Oct 20, 2026
…ining literals (#582) * feat(common): export HoursPerMonth next to HoursPerYear Defined as HoursPerYear / 12 (exactly 730), the average month the aws and gcp code already uses as a bare literal. Part of #109. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(aws,gcp): use common.HoursPerYear and HoursPerMonth for remaining literals Replaces the private hoursPerYear and hoursPerMonth copies in the aws recommendations parser, the 365 * 24 in the aws savingsplans term hours and the 730 * time.Hour savings window in gcp computeengine. Values and types are unchanged (float64 8760 and 730; months/12 stays integer division). Pins the providers and ci_cd_sanity_tests to the pkg branch commit that adds HoursPerMonth; a follow-up re-pins to main after the squash merge (as #571). Skipped on purpose: gcp cloudsql/cloudstorage/memorystore (#471) and azure savingsplans (#491), which have open PRs touching those files. Part of #109. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-pins
providers/aws,providers/azure,providers/gcpandci_cd_sanity_teststo thepkgpseudo-version of main 92722e6.Why: squash merges of #564 and #568 left aws pinned to pkg ff6225d and azure/gcp to 66c6c61. Those are branch commits that are not on main and stay reachable only while the branches exist.
Verification: 92722e6 is an ancestor of origin/main. For each of the four modules, with GOWORK=off and with the workspace,
go build ./...,go vet ./...andgo test -timeout 300s -count=1 ./...all pass. Diff is go.mod/go.sum only (12+/12-).🤖 Generated with Claude Code