Skip to content

GDT: Make tolerance optional #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adamchalmers wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −9
Open

GDT: Make tolerance optional #1349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions modeling-cmds/openapi/api.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@
"properties": {
"dimension": {
"nullable": true,
"description": "The explicitly defined dimension. Only required if the measurement is not automatically calculated.",
"description": "The explicitly defined dimension. Only required if the measurement is not automatically calculated.",
"type": "number",
"format": "double"
},
Expand All @@ -430,14 +430,12 @@
]
},
"tolerance": {
"nullable": true,
"description": "The tolerance of the dimension",
"type": "number",
"format": "double"
}
},
"required": [
"tolerance"
]
}
},
"AnnotationMbdControlFrame": {
"description": "Parameters for defining an MBD Geometric control frame",
Expand Down Expand Up @@ -491,7 +489,7 @@
"maxLength": 1
},
"tolerance": {
"description": "Tolerance value - the total tolerance of the geometric control. The unit is based on the drawing standard.",
"description": "Tolerance value - the total tolerance of the geometric control. The unit is based on the drawing standard.",
"type": "number",
"format": "double"
}
Expand Down
9 changes: 6 additions & 3 deletions modeling-cmds/src/shared.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,8 @@ pub struct AnnotationMbdControlFrame {
pub symbol: MbdSymbol,
/// Diameter symbol (if required) whether the geometric control requires a cylindrical or diameter tolerance
pub diameter_symbol: Option<MbdSymbol>,
/// Tolerance value - the total tolerance of the geometric control. The unit is based on the drawing standard.
/// Tolerance value - the total tolerance of the geometric control.
/// The unit is based on the drawing standard.
pub tolerance: f64,
/// Feature of size or tolerance modifiers
pub modifier: Option<MbdSymbol>,
Expand All @@ -422,10 +423,12 @@ pub struct AnnotationMbdControlFrame {
pub struct AnnotationMbdBasicDimension {
/// Type of symbol to use for this dimension (if required)
pub symbol: Option<MbdSymbol>,
/// The explicitly defined dimension. Only required if the measurement is not automatically calculated.
/// The explicitly defined dimension.
/// Only required if the measurement is not automatically calculated.
pub dimension: Option<f64>,
/// The tolerance of the dimension
pub tolerance: f64,
#[serde(default, skip_serializing_if = "Option::is_none")]
pub tolerance: Option<f64>,
}

/// Parameters for defining an MBD Basic Dimension Annotation state which is measured between two positions in 3D
Expand Down