GDT: Make tolerance optional - #1349
Open
adamchalmers wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1349 +/- ##
=======================================
Coverage ? 33.62%
=======================================
Files ? 36
Lines ? 1805
Branches ? 0
=======================================
Hits ? 607
Misses ? 1198
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
adamchalmers
force-pushed
the
achalmers/gdt-improvements
branch
2 times, most recently
from
August 28, 2026 20:18
624345b to
e1ded48
Compare
Collaborator
Author
adamchalmers
force-pushed
the
achalmers/gdt-improvements
branch
2 times, most recently
from
August 28, 2026 21:42
5a28318 to
8964bd0
Compare
adamchalmers
force-pushed
the
achalmers/gdt-improvements
branch
from
August 28, 2026 21:42
8964bd0 to
cae03a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


The distance/dimension gdt function should not have a hard requirement for a tolerance arg. This is what GD&T is for- to describe the required accuracy of a feature without having to add a tolerance to every dimension.
If tolerance is not sent, no tolerance should be shown. In other words, the leader in the scene should show only the dimension value.