Skip to content

GDT: Make tolerance optional - #1349

Open
adamchalmers wants to merge 1 commit into
mainfrom
achalmers/gdt-improvements
Open

GDT: Make tolerance optional#1349
adamchalmers wants to merge 1 commit into
mainfrom
achalmers/gdt-improvements

Conversation

@adamchalmers

@adamchalmers adamchalmers commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

The distance/dimension gdt function should not have a hard requirement for a tolerance arg. This is what GD&T is for- to describe the required accuracy of a feature without having to add a tolerance to every dimension.

If tolerance is not sent, no tolerance should be shown. In other words, the leader in the scene should show only the dimension value.

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@f6cc760). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1349   +/-   ##
=======================================
  Coverage        ?   33.62%           
=======================================
  Files           ?       36           
  Lines           ?     1805           
  Branches        ?        0           
=======================================
  Hits            ?      607           
  Misses          ?     1198           
  Partials        ?        0           
Flag Coverage Δ
unittests 33.62% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adamchalmers
adamchalmers force-pushed the achalmers/gdt-improvements branch 2 times, most recently from 624345b to e1ded48 Compare August 28, 2026 20:18
@adamchalmers adamchalmers changed the title GDT improvements requested by Nick Boone GDT: Make tolerance optional Aug 28, 2026
@adamchalmers

adamchalmers commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator Author

OK this is what you get if you set tolerance to 0.

Screenshot 2026-08-28 at 3 47 07 PM

vs. setting tolerance to 0.1mm:

Screenshot 2026-08-28 at 3 48 12 PM

So some parts of the engine already support making the tolerance optional. Hopefully this will just be plumbing the data around and not need big changes.

@adamchalmers
adamchalmers force-pushed the achalmers/gdt-improvements branch 2 times, most recently from 5a28318 to 8964bd0 Compare August 28, 2026 21:42
@adamchalmers
adamchalmers force-pushed the achalmers/gdt-improvements branch from 8964bd0 to cae03a8 Compare August 28, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant