-
Notifications
You must be signed in to change notification settings - Fork 31
feat(kiloclaw): enable Exa provider defaults in runtime image #2386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f714551
feat(kiloclaw): wire Exa provider in bundled runtime image
joshavant 17215d9
feat(kiloclaw): auto-assign Exa when search provider is unset
joshavant 174b1cd
style(kiloclaw): format Exa runtime controller and plugin files
joshavant fd8d2d0
fix(kiloclaw): preserve explicit search providers when Exa disabled
joshavant 1fda045
refactor(kiloclaw): unify Exa force and auto-assign branches
joshavant 03a23b6
test(kiloclaw): lock Exa auto-assign behavior for disabled search
joshavant File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARNING: Auto-assignment ignores an explicit disabled state
If an existing config has
tools.web.search.enabled = falseand no provider set, this branch still treats it as missing configuration and re-enables Exa on doctor/restore. That silently turns web search back on for users who explicitly disabled it. Guard the defaulting path onenabled !== falseso only genuinely unset configs are auto-assigned.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intentional for this migration path: when provider is unset, we explicitly default to
kilo-exaon upgraded images, even iftools.web.search.enabledwas previouslyfalse. The preserve rule applies to explicit provider selections, which remain untouched. I added a regression test (auto-assigns kilo-exa even when web search was explicitly disabled but provider is missing) to lock this behavior.