feat(kiloclaw): enable Exa provider defaults in runtime image#2386
Open
feat(kiloclaw): enable Exa provider defaults in runtime image#2386
Conversation
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| customizerWebSearchConfig.enabled = false; | ||
|
|
||
| const braveConfigured = Boolean(env.BRAVE_API_KEY?.trim()); | ||
| if (braveConfigured) { |
Contributor
There was a problem hiding this comment.
WARNING: This overrides explicit non-Exa providers
When KILO_EXA_SEARCH_MODE=disabled and BRAVE_API_KEY is set, this branch rewrites any existing provider to brave. That clobbers explicit selections like perplexity or grok, even though this PR is supposed to preserve explicit providers. Limit the Brave fallback to the unset / existing kilo-exa cases.
Suggested change
| if (braveConfigured) { | |
| if (braveConfigured && (!hasExplicitSearchProvider || config.tools?.web?.search?.provider === KILO_EXA_PROVIDER_ID)) { |
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by gpt-5.4-2026-03-05 · 546,563 tokens |
RSO
approved these changes
Apr 14, 2026
Comment on lines
+329
to
+334
| customizerWebSearchConfig.enabled = true; | ||
| config.tools = config.tools ?? {}; | ||
| config.tools.web = config.tools.web ?? {}; | ||
| config.tools.web.search = config.tools.web.search ?? {}; | ||
| config.tools.web.search.enabled = true; | ||
| config.tools.web.search.provider = KILO_EXA_PROVIDER_ID; |
Contributor
There was a problem hiding this comment.
I think this is the same as the branch on line 302? If so, can't we just write if (kiloExaSearchMode === "kilo-proxy" || kiloExaSearchmode === "unset")?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createTool()soft-disable behavior.kilo-proxy/disabled/ unset), preserve explicit providers, and auto-assignkilo-exawhen provider is missing on upgraded images.Verification
pnpm --filter kiloclaw test -- controller/src/config-writer.test.tspnpm test -- src/kilo-exa-web-search-provider.test.ts(inservices/kiloclaw/plugins/kiloclaw-customizer)git push -u origin feat/kiloclaw-exa-image-runtime(pre-push checks passed:oxfmt --list-different .and affected-package typecheck)Visual Changes
Reviewer Notes