Repository navigation
Validate empty and null JSON columns - #27
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 93.61% 93.75% +0.13%
==========================================
Files 1 1
Lines 94 96 +2
==========================================
+ Hits 88 90 +2
Misses 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
quinnj
force-pushed
the
maintenance/column-lengths
branch
from
October 14, 2026 00:25
7d72b62 to
c6ecf9a
Compare
Keep zero-length columns initialized for equal-length validation. Map all-null element types to Missing and empty bottom element types to Any so the table schema can represent them. Cover public schema and row/column conversions without changing populated-column types. AI disclosure: This work was prepared with assistance from OpenAI Codex.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
quinnj
force-pushed
the
maintenance/column-lengths
branch
from
October 14, 2026 00:56
c6ecf9a to
b98b669
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #26; its row-input and CI foundation is included until that PR merges. The additional change covers the JSON object-of-arrays path.
An empty first column currently disables equal-length validation:
{"a":[],"b":[1]}is accepted even though its columns have different lengths. Recognize the first column using the existing column-name count so zero remains a valid initialized length.An entirely null column also throws
UndefVarErrorbecause the union method does not bind its type parameter forNothing. Handle that exact type asMissing. Empty parsed arrays can haveUnion{}as their element type; useAnyfor those unknown column types so constructing a table schema and converting the empty table succeeds on current Julia. Populated and mixed-null column types retain their existing handling.Validation:
git diff --checkpasses.7d72b625be0d176313a65d913c3dedfb1291b03e: all four native jobs in run 37186035745, including Julia 1.0, plus both Codecov checks. All four coverage sessions were accepted at the correct repository/commit destination; the stable job uploaded 893 bytes and the final report is 93.75%. Merge remains held for prerequisite Restore JSON row inputs and missing fields after empty rows #26 and the required independent approval.Co-authored by Codex
AI disclosure: This work was prepared with assistance from OpenAI Codex.