Repository navigation
Report scalar element types for JSON columns - #28
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 93.75% 93.81% +0.06%
==========================================
Files 1 1
Lines 96 97 +1
==========================================
+ Hits 90 91 +1
Misses 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
quinnj
force-pushed
the
maintenance/column-element-types
branch
from
October 14, 2026 00:25
9923fe1 to
efe0e8d
Compare
Distinguish a column wrapper's value type from its stored source-array type. Reuse null/empty type conversion so AbstractVector element types agree with table schemas and collect succeeds while reads keep the source array. Preserve existing nested copy behavior. AI disclosure: This work was prepared with assistance from OpenAI Codex.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
quinnj
force-pushed
the
maintenance/column-element-types
branch
from
October 14, 2026 01:02
efe0e8d to
4d10ffa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #27 and its #26 foundation. This follow-up corrects the element type of returned JSON columns.
For
jsontable("{\"a\":[1,2]}"), the schema declares integer values but the returned column currently declares a JSON array as its element type.collect(column)then tries to convert each integer into that array type and throwsMethodError. Null-converting columns have the same mismatch.Give the wrapper separate parameters for its scalar element type and its source array type. Reuse the existing column-type conversion, retaining the source array field and direct indexing without copying it. Column access through a name, position, or property now advertises the same value type as the schema.
Validation:
collectand existingcopybehavior.git diff --checkpasses.9923fe14f59c0acc884c0f810aca91c31dec6f70: all four native jobs in run 37186473791, including Julia 1.0, plus both Codecov checks. All four coverage sessions were accepted at the correct repository/commit destination; the stable job uploaded 889 bytes and the final report is 95.87%. Merge remains held for prerequisite Validate empty and null JSON columns #27 and required independent approval.Co-authored by Codex
AI disclosure: This work was prepared with assistance from OpenAI Codex.