Repository navigation
Validate gateway destinations before credentialed dispatch - #98
Conversation
CompleteDotTech
left a comment
There was a problem hiding this comment.
Independent offline review of b9e57f8; freshly rechecked unchanged head and full patch. No actionable code defect found in exact destination validation, config copying/revalidation before state serialization, immutable policy, or redirect blocking.
Validation: full pytest 681 passed / 46 optional-integration skips; gateway tests 152 passed with typesafe-sdk 0.7.0 installed; Ruff passed. An additional 60 synthetic checks covered all five routes, control-character/Unicode/string-subclass/wrong-route destinations, and relative/scheme-relative/HTTP/HTTPS/self redirects, using MockTransport only. Exact-head hosted tests also passed: https://github.com/Jev-Engineering/TypeWright/actions/runs/37119106070.
This is a COMMENT, not merge approval. Endpoint-policy owner approval and private live-configuration compatibility review for #88 remain unresolved gates. Passing offline tests does not qualify live providers or authorize adoption. No real credentials, operator .env.local, study inputs, or provider calls were used.
|
Fresh-context review (round 1) of head b9e57f8 Scope: I read the full diff ( Validation (run locally, Python 3.14.8, dspy/gepa/typesafe-sdk absent)
Correctness and invariants
Findings
REVIEW CLEAN |
The exact HTTPS URL pinning for gateway routes is now owner-approved (#88). Replace "proposed / pending approval" wording in the README, the policy comment and the user-facing error with the approved, enforced policy, keeping the caveat that no operator .env.local was inspected and no live route qualification was done. Tighten the two tests that match the error text to the new wording, and add a CHANGELOG entry for the fail-at-startup behavior change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
b9e57f8 to
edbc82d
Compare
|
Fresh-context review (round 2) of head edbc82d I reviewed the diff, the code it touches ( Executed locallyPython 3.14.8, PR head checked out in an isolated worktree,
What I verified
Findings
No BLOCKING findings. REVIEW CLEAN Not executed: live or paid provider calls, live worker or route qualification, inspection of any operator |
|
Coordinator: approved for merge on head edbc82d after review round 2 posted REVIEW CLEAN (round 1 also clean; its NITs were fixed in edbc82d). All 10 hosted checks pass on this exact head. Left as noted NITs, not fixed (README wording only; changing it would move the head and need another review round):
.env.local host check: no |
Problem
Gateway route configuration accepted arbitrary destinations for credentialed study requests, so a misconfigured or hostile
.env.localcould send route credentials and study state to any host.Change
MappingProxyType), and redirects are disabled at client construction and per request.CHANGELOG.mdentry: a worker whose.env.localpoints routes 3-5 at any other host, port or path now fails at startup, before any credential is sent.main(6532cc8).No operator
.env.localwas inspected, no live worker configuration was changed and no provider request was made. This PR does not establish live route qualification.Closes #88
Validation
Local, Python 3.14.8, dspy/gepa/typesafe-sdk absent:
pytest -q: 737 passed, 79 skipped (main baseline is 606 passed / 79 skipped; the added tests are the new gateway cases).pytest -q tests/test_gateway_routes.py: 151 passed, 1 skipped (TypeSafe SDK absent).ruff check src tests examples: clean.MANIFEST.sha256is touched.httpx.MockTransportonly.An independent code review passed the security mechanics. Its mutable-policy finding was addressed with
MappingProxyTypeand regression coverage, and its follow-up NITs (stale wording, CHANGELOG, rebase) are addressed here.Not executed: live or paid provider calls, live worker or route qualification, private destination-compatibility review against operator configuration.
🤖 Generated with Claude Code