Repository navigation
Document exact pins versus floating dependencies - #106
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Fresh-context review (round 1) of head 7e6a64e Local results (Python 3.14.8, dspy/gepa/typesafe-sdk absent)
The Python dependency tables match FindingsBLOCKING:
|
|
Round 1 findings addressed in 513736c (rebased on current origin/main, 6532cc8):
I mutation-checked the tests, reverting each change afterwards. Moving |
List every exact pin and bounded range declared in pyproject.toml and the gateway example requirements, state that transitive packages are unpinned and unhashed, that CI resolves fresh on every run, and that no lock file exists. Link the section from the README and add a regression test that derives the expected list from pyproject.toml. Refresh the three touched MANIFEST entries. Refs #50 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The dependency section said the repository has no lock file, but it tracks the npm lock for the Node gateway smoke (ai pinned at 7.0.114, integrity hashes) and a stale Windows/CPython 3.13 pip freeze in reports/. Scope the claim to the Python package, name both files with their scope, and mark the freeze as historical and not authoritative. The lock test now walks the source tree (skipping ignored and local-only directories) for lock-like names and requires each to be named in the section. The table test also checks the Declared in column against pyproject extras, and a new test ties the build-system sentence to [build-system].requires and the npm pins to package.json. Refs #50 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
513736c to
701169d
Compare
|
Fresh-context review (round 2) of head 701169d Scope: #50, "dependency honesty" item only. I read the diff, Validation (local, Python 3.14.8, dspy/gepa/typesafe-sdk/numpy absent)
Findings
The dependency-honesty acceptance item is met. The docs say which Python requirements are exact pins and which float, that transitive packages float and are unhashed, and that CI resolves fresh on every run. They also name the real npm lock and the stale freeze with their scope, and no lock was fabricated. This PR does not address the other #50 items (CI, branch protection, stale branches), which is consistent with REVIEW CLEAN |
|
Coordinator: approved for merge on head 701169d. Review round 2 posted REVIEW CLEAN. Round 1 found 2 BLOCKING items (the false 'no lock file' claim and a lock test that only checked the repo root), and both were fixed in this head. All 10 hosted checks pass on this exact head. Round-2 NITs are left as noted, not fixed, because fixing them would move the head and need another review round:
|
Problem
README.md and docs/INTEGRATIONS.md said the pins are "not a fully resolved dependency lock" but never said which requirements are exact and which float, or which tracked files are locks.
Change
docs/INTEGRATIONS.md: new "Pinned and floating dependencies" section.examples/ai-gateway/package-lock.jsonis a real npm lock (lockfileVersion 3,integrityhashes) for the optional Node gateway smoke only, withaipinned at7.0.114inpackage.json.reports/resolved-lock-windows-py313.txtis a stale historicalpip freeze(2026-09-19, CPython 3.13.13 on Windows, oldsystemone-compilername,dspy==3.3.1), not maintained and not authoritative. That file is not modified.typesafe-sdk==0.7.0,dspy[typesafe]==3.4.0,dspy[litellm,typesafe]==3.4.0,gepa==0.1.4), every bounded range frompyproject.tomlandexamples/ai-gateway/requirements.txt, and the[build-system]bounds.README.md: the existing sentence now names the exact Python pins, says the Python package has no current resolved lock, names the npm lock and the stale freeze, and links to the new section.tests/test_packaging_metadata.py: four new tests, all deriving expectations from the declared files rather than from the doc.[build-system].requires.examples/ai-gateway/package.jsondependency must be an exact pin that the section names..git, venvs,node_modules,runs,.claude, caches, build output, and other ignored directories. It looks for lock-like names (package-lock.json,yarn.lock,pnpm-lock.yaml,poetry.lock,uv.lock,Pipfile.lock,pdm.lock,*.lock,*lock*.txt,*lock*.toml,constraints*.txt,*freeze*.txt, and so on) and requires each one found to be named in the section.CHANGELOG.mdentry; refreshedMANIFEST.sha256entries forREADME.md,docs/INTEGRATIONS.mdandtests/test_packaging_metadata.pyonly.No lock was generated. Nothing about dependency resolution was verified beyond reading the declared files.
Validation (local, Python 3.14.8, dspy/gepa/typesafe-sdk absent)
pytest -q: 741 passed, 79 skipped on the rebased head (this PR adds 4 tests intests/test_packaging_metadata.py; skips unchanged; before the rebase onto 3859256: 610 passed vs 606 baseline on 6532cc8)ruff check src tests examples: cleanoptimizefrom thegepa==0.1.4row, droppingwheelfrom the build-system sentence, and removing the backticked freeze path from the section each made the corresponding test fail.sha256sum -c. A fullsha256sum -c MANIFEST.sha256already fails on origin/main (pre-existing stale entries plus missingsrc/s1compiler/...paths from the rename). This PR does not touch those entries; they need a separate refresh.Not executed
No live, paid, or hosted-provider calls. No
npm cior Node smoke run. No optional SDK integration tests locally (SDKs absent; skips preserved).Refs #50
🤖 Generated with Claude Code