Repository navigation
Add the Console Waterfall page - #863
Merged
Merged
Conversation
This was referenced Oct 20, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds page 4, Waterfall, with exact Command selection, nested Runs/stages/tool calls, and one shared time axis.
Tool intervals extend to the next matched Session call or stage boundary and include waiting. The page labels this distinction from measured execution time. Both
show --jsonandlogsare registered in CLI parity.Closes #827
Evidence
After:
cargo test --test consolepasses all 16 tests, covering real-shaped Claude/Codex events, duplicate calls/item updates, scoped Ticket Runs, unmatched calls, midnight rollover, fractional boundaries and CLI data parity.logsparity metadata.After: all three exact reviewer commands pass. Portable retained checks:
python3 console/reproductions/waterfall-fractional.py,python3 console/reproductions/waterfall-stage.py,python3 console/reproductions/waterfall-parity.py.cargo check --all-targets,cargo fmt --check,cargo clippy --all-targets -- -D warnings, and the route parity test pass.cd console && npm test: 14 passed. Checks nested bar alignment/scale, Command chips, Session links, escaping, keys 4/f and 390 px layout. The final run also corrected an existing navigation test's stale expectation that key 4 was unavailable.cargo test: full Rust suite passed (repository-configured ignored tests remain ignored).Merge Danger
Door: two-way
Revert the commits to remove the page and its reader.
Blast Radius: Console
Reads retained local logs when loading a selected Command. Tool durations represent recorded intervals; unmatched evidence remains visible without a time.
Test seams
show --json,logs) and Console HTTP over isolated fixture records and real-shaped Session/Command logs.Unaddressed findings
Standards
Spec
None. All three findings were reproduced as written, fixed, and kept as passing regression checks.
Review coverage
Standards and Spec independently reviewed against fetched
issue-776commit56938c1f8fe1afb36be72bfac96d825a988dbfb2, including one coverage follow-up each. Both read 15 of 16 changed files; no generated-output exclusions.The review left
console/tests/inbox.test.cjsunread on both axes. Its late test-only correction adds Waterfall to the key/page and jump-letter loops and removes the unavailable-key assertion. The primary agent inspected this diff, ran its targeted navigation check, and ran all 14 browser tests successfully.Final findings, dispositions, each axis's complete files-read list and unread disclosure are retained locally in
.thirdshift-review-xVlImL/standards.mdand.thirdshift-review-xVlImL/spec.md.Built with codex · gpt-6.1-sol · high