Skip to content

Carry exact Command ownership through Session logs and child Runs - #799

Merged
JacobStephens2 merged 4 commits into
issue-794from
issue-796
Oct 19, 2026
Merged

JacobStephens2 merged 4 commits into
issue-794from
issue-796

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

Summary

Keep Session transcripts, Model evidence and review reports with their exact Command, even when Commands share an issue and start second.

Command starts work → allocate {stamp, token, Command-log path}
  Pass dispatch / Ticket Run / nested Base fix → inherit that owner
  Session / Resume / Repair → <subject>-<stamp>~<token>-<kind>
  notification → decode owner + compare exact Command-log path

Legacy logs remain readable in place. Closes #796.

Evidence

  • Before: cargo test same_second_commands_keep_session_model_and_review_contents_separate -- --nocapture failed with lost first Session after the second Command replaced the first transcript.
    After: the regression passes and verifies both transcripts, Model notification markers and retained Standards/Spec reports. CLI fixtures verify disjoint owned and legacy Session inventories; the nested Spec → Ticket → Base-fix scenario verifies shared ownership through actual child Runs.
  • Final validation: cargo fmt --check, cargo clippy --all-targets -- -D warnings, cargo test, cd site && npm test (13 tests), Python script tests and the pinned cargo-dist release-generator freshness check.
  • The existing BrokenPipe recovery fixture now retains the owner token when injecting its failing Session log. Its exact regression command passes: cargo test --test progress_lines a_log_failure_still_recovers_and_reports_warnings_and_usage -- --exact --nocapture.

Test seams

  • Command owner allocation/capture and inherited child metadata, through real temporary files and the existing deterministic recording adapter.
  • Session naming/execution and retained review reports through Logs, Recording and Sessions.
  • CLI status/show/logs/Stop, child Ticket/Base-fix Runs and notification delivery through existing fixture-owned processes.

Review

Reviewed against issue-794 at 7a95e111fdadce6b9d6d2e52007a2b0a959b7341.

  • Standards: three naming/duplication findings, all addressed and confirmed in follow-up review.
  • Spec: no findings.
  • Both axes read all 19 changed files, including generated site/docs/index.html. Unread changed files: none. Generated-output exclusions: none.

Unaddressed findings

  • Standards: none.
  • Spec: none.

Merge Danger

Door: two-way

No existing logs are moved, rewritten or deleted.

Blast Radius: Logging

Session evidence, inherited ownership and log observation compatibility.

Built with codex · gpt-6.1-sol · high

@JacobStephens2
JacobStephens2 merged commit 3fde7d8 into issue-794 Oct 19, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-796 branch October 19, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant