Skip to content

fix(signals): classify vue/svelte/astro source maps as generated#3357

Merged
JSONbored merged 1 commit into
JSONbored:mainfrom
jimcody1995:fix/path-matchers-frontend-sourcemaps
Jul 5, 2026
Merged

fix(signals): classify vue/svelte/astro source maps as generated#3357
JSONbored merged 1 commit into
JSONbored:mainfrom
jimcody1995:fix/path-matchers-frontend-sourcemaps

Conversation

@jimcody1995

Copy link
Copy Markdown
Contributor

Summary

Scope

  • Conventional Commit title format.
  • Focused — path-matchers + unit tests only.
  • Follows CONTRIBUTING.md.
  • No linked issue needed.

Validation

  • git diff --check
  • npm run test:ci on Node 22
  • npm audit --audit-level=moderate — 0 vulnerabilities
  • Unit tests cover .vue.map, .svelte.map, .astro.map

Safety

  • No secrets, auth, or UI changes.
  • N/A for UI Evidence.

UI Evidence

N/A — backend path classifier only.

Notes

Conflict avoidance: Touches only src/signals/path-matchers.ts and test/unit/path-matchers.test.ts. Zero overlap with open PRs (#3316 dart, #3304 review holds, #3350 api auth, #3340 engine, #3339 enrichment, #3314 miner, #3305 enrichment-wire, #3281 grafana). Merges cleanly after any of those land without rebase.

Made with Cursor

Vite/Rollup emit .vue.map/.svelte.map/.astro.map siblings for
framework sources; slop already treated .ts/.mts maps as generated
but missed these spellings after vue/svelte/astro became code.

Co-authored-by: Cursor <cursoragent@cursor.com>
@jimcody1995 jimcody1995 requested a review from JSONbored as a code owner July 5, 2026 04:45
@superagent-security

Copy link
Copy Markdown

Superagent didn't find any vulnerabilities or security issues in this PR.

@gittensory-orb gittensory-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.5x multiplier. label Jul 5, 2026
@gittensory-orb

gittensory-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-05 04:45:36 UTC

2 files · 1 AI reviewer · no blockers · readiness 80/100 · CI pending · blocked

⏸️ Suggested Action - Manual Review

Review summary
The change correctly extends the generated-file source-map regex so `.vue.map`, `.svelte.map`, and `.astro.map` normalize into the same generated category as existing JS/TS/CSS maps. The added unit coverage exercises `isGeneratedFile` on the new extensions, and `classifyChangedFile` already routes through `isGeneratedFileFrom` before source classification, so the runtime path is covered by the implementation. I do not see a reachable correctness defect in the visible diff.

Nits — 4 non-blocking
  • nit: `src/signals/path-matchers.ts:65` still describes the regex as "every first-class JS/TS bundle extension" even though the expression now includes CSS plus Vue/Svelte/Astro; update the comment so the documented scope matches the matcher.
  • nit: `test/unit/path-matchers.test.ts:40` only asserts `isGeneratedFile`; because the PR description calls out `classifyChangedFile`, add at least one direct classification assertion for a framework source map to lock the end-to-end category.
  • Update the comment above the source-map regex in `src/signals/path-matchers.ts:65` to mention front-end framework single-file component source maps, not just JS/TS.
  • Add `expect(classifyChangedFile("dist/App.vue.map")).toBe("generated")` or equivalent in `test/unit/path-matchers.test.ts` so the claimed misclassification path is directly covered.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ No-issue rationale PR body explains why no issue is linked.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 46 registered-repo PR(s), 23 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor jimcody1995; Gittensor profile; 46 PR(s), 0 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: jimcody1995
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 46 PR(s), 0 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.88%. Comparing base (f940f45) to head (8a687cc).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3357   +/-   ##
=======================================
  Coverage   93.88%   93.88%           
=======================================
  Files         280      280           
  Lines       30562    30562           
  Branches    11132    11132           
=======================================
  Hits        28694    28694           
  Misses       1211     1211           
  Partials      657      657           
Files with missing lines Coverage Δ
src/signals/path-matchers.ts 88.46% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.5x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants