Skip to content

feat(engine): add pickTopRankedOpportunitiesAtOrAboveScore helper#3360

Merged
gittensory-orb[bot] merged 1 commit into
JSONbored:mainfrom
kiannidev:feat/engine-pick-top-ranked-min-score
Jul 5, 2026
Merged

feat(engine): add pickTopRankedOpportunitiesAtOrAboveScore helper#3360
gittensory-orb[bot] merged 1 commit into
JSONbored:mainfrom
kiannidev:feat/engine-pick-top-ranked-min-score

Conversation

@kiannidev

Copy link
Copy Markdown
Contributor

Summary

  • Add pickTopRankedOpportunitiesAtOrAboveScore(candidates, minScore, limit) to @jsonbored/gittensory-engine: filters via rankOpportunitiesAtOrAboveScore, then returns the top N survivors.
  • Non-finite or zero limits fail closed to an empty list.
  • New file ranked-opportunity-top-min-score.ts — generic-ranker mirror of merged feat(engine): add pickTopMetadataOpportunitiesAtOrAboveScore helper #3340 metadata helper.

Why no linked issue

Completes the generic discovery ranker toolkit (rank → threshold → top-N) without callers chaining helpers manually.

Conflict avoidance

Touches only packages/gittensory-engine/src/ranked-opportunity-top-min-score.ts (new), packages/gittensory-engine/src/index.ts (one export line), and test/unit/ranked-opportunity-top-min-score.test.ts (new). No overlap with open PRs (#3357 signals, #3356 enrichment, #3314 miner CLI, #3304 review holds, #3305 enrichment-wire).

Codecov patch

Local diff-cover reports 100% patch coverage on ranked-opportunity-top-min-score.ts.

Test plan

  • npm run build --workspace @jsonbored/gittensory-engine
  • npm run build:miner
  • npx vitest run test/unit/ranked-opportunity-top-min-score.test.ts (6 tests)
  • diff-cover coverage/lcov.info --compare-branch=main --fail-under=99 → 100%
  • CI validate / validate-code / codecov patch+project / orb review agent

Made with Cursor

Compose generic ranker min-score filtering with a top-N cap for
discovery callers that need threshold plus limit in one helper.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kiannidev kiannidev requested a review from JSONbored as a code owner July 5, 2026 04:53
@superagent-security

Copy link
Copy Markdown

Superagent didn't find any vulnerabilities or security issues in this PR.

@gittensory-orb gittensory-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 1.25x multiplier. label Jul 5, 2026
@gittensory-orb

gittensory-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-05 04:58:02 UTC

3 files · 1 AI reviewer · no blockers · readiness 55/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
The AI review returned non-blocking notes for this change but did not include a separate narrative summary. Review the nits below before deciding this PR.

Nits — 5 non-blocking
  • nit: packages/gittensory-engine/src/ranked-opportunity-top-min-score.ts:5 documents only non-finite limits, but the implementation also truncates fractional limits and clamps negative limits to empty, so the public contract should say that explicitly.
  • nit: test/unit/ranked-opportunity-top-min-score.test.ts:44 covers zero, negative, NaN, and Infinity, but not fractional finite limits, which are a visible behavior introduced by Math.trunc at packages/gittensory-engine/src/ranked-opportunity-top-min-score.ts:13.
  • packages/gittensory-engine/src/ranked-opportunity-top-min-score.ts:5: update the JSDoc to match the implemented contract, e.g. `Non-finite and non-positive limits return an empty list; positive fractional limits are truncated.`
  • test/unit/ranked-opportunity-top-min-score.test.ts:44: add a focused assertion for a fractional limit such as `2.9` returning exactly two entries so callers do not have to infer the truncation behavior.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 1334 registered-repo PR(s), 648 merged, 49 issue(s).
Contributor context ✅ Confirmed Gittensor contributor kiannidev; Gittensor profile; 1334 PR(s), 49 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: kiannidev
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 1334 PR(s), 49 issue(s).
  • Related work: Titles/paths share 10 meaningful terms. (issue #2038, issue #2040)
  • Related work: Titles/paths share 7 meaningful terms. (issue #2995, issue #2568)
  • Related work: Titles/paths share 5 meaningful terms. (issue #1477, issue #1514)
  • Additional title-only matches omitted; title-only overlap does not block.
Contributor next steps
  • Explain no-issue PR.
  • Review top overlaps.
  • Add a concise scope and risk note.
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.88%. Comparing base (d638678) to head (d15d82f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3360   +/-   ##
=======================================
  Coverage   93.88%   93.88%           
=======================================
  Files         281      282    +1     
  Lines       30566    30570    +4     
  Branches    11134    11136    +2     
=======================================
+ Hits        28698    28702    +4     
  Misses       1211     1211           
  Partials      657      657           
Files with missing lines Coverage Δ
...ory-engine/src/ranked-opportunity-top-min-score.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gittensory-orb gittensory-orb Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@gittensory-orb gittensory-orb Bot merged commit 3e7390f into JSONbored:main Jul 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 1.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant