fix(signals): classify .mts and .cts source maps as generated#3347
Conversation
Module TypeScript bundlers emit .mts.map/.cts.map siblings; slop path-matchers already treated .mjs/.cjs maps as generated but not these spellings, so they were miscounted as substantive source. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3347 +/- ##
=======================================
Coverage 93.88% 93.88%
=======================================
Files 280 280
Lines 30552 30552
Branches 11130 11130
=======================================
Hits 28684 28684
Misses 1211 1211
Partials 657 657
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-05 04:37:06 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 3 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Summary
isGeneratedFileinpath-matchers.tsto treat.mts.mapand.cts.mapas generated output, matching the existing.mjs.map/.cjs.map/.ts.maphandling.classifyChangedFilemiscounted them as substantive source effort.Scope
CONTRIBUTING.md.Validation
git diff --checknpm run test:cion Node 22 (actionlint, typecheck, test:coverage, workers, MCP, UI)npm audit --audit-level=moderate— 0 vulnerabilities.mts.mapand.cts.mapinisGeneratedFileSafety
UI Evidence
N/A — backend path classifier only.
Notes
Conflict avoidance: Touches only
src/signals/path-matchers.tsandtest/unit/path-matchers.test.ts. Zero overlap with open PRs (#3316 dart classifiers, #3304 review holds, #3344/#3343/#3339 enrichment, #3340 engine, #3314 miner, #3305 enrichment-wire, #3281 grafana, #3255 queue). Should merge cleanly after any of those land without rebase.Made with Cursor