Skip to content

fix(signals): classify .mts and .cts source maps as generated#3347

Merged
gittensory-orb[bot] merged 1 commit into
JSONbored:mainfrom
jimcody1995:fix/path-matchers-mts-cts-sourcemaps
Jul 5, 2026
Merged

fix(signals): classify .mts and .cts source maps as generated#3347
gittensory-orb[bot] merged 1 commit into
JSONbored:mainfrom
jimcody1995:fix/path-matchers-mts-cts-sourcemaps

Conversation

@jimcody1995

Copy link
Copy Markdown
Contributor

Summary

  • Extend isGeneratedFile in path-matchers.ts to treat .mts.map and .cts.map as generated output, matching the existing .mjs.map/.cjs.map/.ts.map handling.
  • TypeScript module bundlers emit these source-map siblings; without this, slop classifyChangedFile miscounted them as substantive source effort.

Scope

  • Conventional Commit title format.
  • Focused change — path-matchers + unit tests only.
  • Follows CONTRIBUTING.md.
  • No linked issue needed (small classifier parity fix).

Validation

  • git diff --check
  • npm run test:ci on Node 22 (actionlint, typecheck, test:coverage, workers, MCP, UI)
  • npm audit --audit-level=moderate — 0 vulnerabilities
  • Unit tests cover .mts.map and .cts.map in isGeneratedFile

Safety

  • No secrets, auth, or UI changes.
  • N/A for UI Evidence.

UI Evidence

N/A — backend path classifier only.

Notes

Conflict avoidance: Touches only src/signals/path-matchers.ts and test/unit/path-matchers.test.ts. Zero overlap with open PRs (#3316 dart classifiers, #3304 review holds, #3344/#3343/#3339 enrichment, #3340 engine, #3314 miner, #3305 enrichment-wire, #3281 grafana, #3255 queue). Should merge cleanly after any of those land without rebase.

Made with Cursor

Module TypeScript bundlers emit .mts.map/.cts.map siblings; slop
path-matchers already treated .mjs/.cjs maps as generated but not
these spellings, so they were miscounted as substantive source.

Co-authored-by: Cursor <cursoragent@cursor.com>
@jimcody1995 jimcody1995 requested a review from JSONbored as a code owner July 5, 2026 04:28
@superagent-security

Copy link
Copy Markdown

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.88%. Comparing base (38a1bac) to head (38c6ce2).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3347   +/-   ##
=======================================
  Coverage   93.88%   93.88%           
=======================================
  Files         280      280           
  Lines       30552    30552           
  Branches    11130    11130           
=======================================
  Hits        28684    28684           
  Misses       1211     1211           
  Partials      657      657           
Files with missing lines Coverage Δ
src/signals/path-matchers.ts 88.46% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gittensory-orb gittensory-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.5x multiplier. label Jul 5, 2026
@gittensory-orb

gittensory-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-05 04:37:06 UTC

2 files · 1 AI reviewer · no blockers · readiness 80/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This is a focused classifier parity fix: `isGeneratedFileFrom` now treats `.mts.map` and `.cts.map` as generated source maps alongside the existing JS/TS bundle map extensions. The production path is direct because `classifyChangedFile` calls `isGeneratedFileFrom` before `isCodeFile`, so these files now land in `generated` instead of being miscounted as source/other. The added tests exercise the matcher itself, and the regex remains path-normalized and end-anchored enough for this case.

Nits — 3 non-blocking
  • nit: `test/unit/path-matchers.test.ts:43` only asserts `isGeneratedFile`, so the slop-facing regression path through `classifyChangedFile` is not directly covered even though that is the behavior named in the PR description.
  • Add `dist/loader.mts.map` and `dist/setup.cts.map` to the `classifyChangedFile` representative cases in `test/unit/path-matchers.test.ts` with expected category `generated`, so the test pins the actual caller path that prevents source-effort miscounting.
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ No-issue rationale PR body explains why no issue is linked.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 46 registered-repo PR(s), 23 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor jimcody1995; Gittensor profile; 46 PR(s), 0 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: jimcody1995
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 46 PR(s), 0 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@gittensory-orb gittensory-orb Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@gittensory-orb gittensory-orb Bot merged commit f940f45 into JSONbored:main Jul 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.5x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant