-
Notifications
You must be signed in to change notification settings - Fork 23
Align conda-forge recipe with normal recipe #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
81591cb
2197063
bc89e74
940fe06
573457b
2bdd772
11b97d9
39b8b26
c6c5e80
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| set MKLROOT=%PREFIX% | ||
| %PYTHON% -m pip install --no-build-isolation --no-deps . | ||
| %PYTHON% setup.py build --force install --old-and-unmanageable | ||
| if errorlevel 1 exit 1 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| #!/bin/bash -x | ||
|
|
||
| export MKLROOT=$PREFIX | ||
| export CFLAGS="-I$PREFIX/include $CFLAGS" | ||
| $PYTHON -m pip install --no-build-isolation --no-deps . | ||
| # make sure that compiler has been sourced, if necessary | ||
|
|
||
| export MKLROOT=${PREFIX} | ||
| $PYTHON setup.py build --force install --old-and-unmanageable |
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,16 @@ | ||||||||||||||||||||||
| c_compiler: # [linux] | ||||||||||||||||||||||
| - gcc # [linux] | ||||||||||||||||||||||
| cxx_compiler: # [linux] | ||||||||||||||||||||||
| - gxx # [linux] | ||||||||||||||||||||||
| cxx_compiler_version: # [linux] | ||||||||||||||||||||||
| - '14' # [linux] | ||||||||||||||||||||||
| c_stdlib: # [linux] | ||||||||||||||||||||||
| - sysroot # [linux] | ||||||||||||||||||||||
| c_stdlib_version: # [linux] | ||||||||||||||||||||||
| - '2.28' # [linux] | ||||||||||||||||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's set to |
||||||||||||||||||||||
| c_stdlib: # [win] | ||||||||||||||||||||||
| - vs # [win] | ||||||||||||||||||||||
| cxx_compiler: # [win] | ||||||||||||||||||||||
| - vs2022 # [win] | ||||||||||||||||||||||
| c_compiler: # [win] | ||||||||||||||||||||||
| - vs2022 # [win] | ||||||||||||||||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As an option we can list all python versions:
Suggested change
it would mean if we run
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also, the feedstock adds: pin_run_as_build:
python:
min_pin: x.x
max_pin: x.xwhich we would probably able to do as well. |
||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,29 +1,33 @@ | ||||||
| {% set version = "2.2.0dev1" %} | ||||||
| {% set buildnumber = 0 %} | ||||||
|
|
||||||
| package: | ||||||
| name: mkl_fft | ||||||
| version: {{ version }} | ||||||
| version: {{ GIT_DESCRIBE_TAG }} | ||||||
|
|
||||||
| source: | ||||||
| path: ../ | ||||||
|
|
||||||
| build: | ||||||
| number: {{ buildnumber }} | ||||||
| number: {{ GIT_DESCRIBE_NUMBER }} | ||||||
| script_env: | ||||||
| - WHEELS_OUTPUT_FOLDER | ||||||
|
Comment on lines
+10
to
+11
|
||||||
| script_env: | |
| - WHEELS_OUTPUT_FOLDER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds as a valid comment. We don't pass WHEELS_OUTPUT_FOLDER env to the scripts. Probably we should remove that env here.
ndgrigorian marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's present in the feedstock repo. Why do we plan to remove that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conda-remove-defaults:still used in.github/workflows/build_pip.yaml, but can be removed