Align conda-forge recipe with normal recipe by ndgrigorian · Pull Request #285 · IntelPython/mkl_fft

ndgrigorian · 2026-03-06T05:31:17Z

This PR proposes to align the meta.yaml in conda-recipe-cf with conda-recipe

Also removes MSVC setup step, instead using conda build configs to set VS version. This exposed mistake in conda build config, which was set to vs2017

Copilot

Pull request overview

Aligns the conda-forge recipe (conda-recipe-cf) metadata and CI behavior closer to the primary conda recipe (conda-recipe) to standardize versioning/build metadata and dependencies.

Changes:

Update conda-recipe-cf/meta.yaml to use GIT_DESCRIBE_TAG / GIT_DESCRIBE_NUMBER, add script_env, and align several build/host/run requirements.
Adjust recipe metadata text (summary/description) and simplify import checks under test:.
Remove the explicit MSVC setup step from the Windows conda-package workflows.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

File	Description
`conda-recipe-cf/meta.yaml`	Switch to git-describe versioning/build numbering; add build env forwarding and align dependency list/metadata.
`.github/workflows/conda-package.yml`	Remove MSVC environment setup step before Windows conda build.
`.github/workflows/conda-package-cf.yml`	Remove MSVC environment setup step before Windows conda build (NumPy 2.x matrix).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-06T05:34:56Z

conda-recipe-cf/meta.yaml

+    script_env:
+      - WHEELS_OUTPUT_FOLDER


build.script_env now forwards WHEELS_OUTPUT_FOLDER, but the conda-forge recipe’s build scripts (conda-recipe-cf/build.sh and conda-recipe-cf/bld.bat) don’t reference this variable, so this setting is currently dead/unused and may confuse future maintainers. Either remove WHEELS_OUTPUT_FOLDER from script_env for this recipe or update the conda-forge build scripts to honor it (similar to conda-recipe/).

Suggested change

script_env:

- WHEELS_OUTPUT_FOLDER

It sounds as a valid comment. We don't pass WHEELS_OUTPUT_FOLDER env to the scripts. Probably we should remove that env here.

conda-recipe-cf/meta.yaml

antonwolfy · 2026-03-10T11:19:49Z

conda-recipe-cf/meta.yaml

    imports:
      - mkl_fft
      - mkl_fft.interfaces
-      - mkl_fft.interfaces.numpy_fft


It's present in the feedstock repo. Why do we plan to remove that?

antonwolfy · 2026-03-10T11:22:03Z

conda-recipe-cf/meta.yaml

+    script_env:
+      - WHEELS_OUTPUT_FOLDER


It sounds as a valid comment. We don't pass WHEELS_OUTPUT_FOLDER env to the scripts. Probably we should remove that env here.

antonwolfy · 2026-03-10T11:24:10Z

conda-recipe-cf/conda_build_config.yaml

+c_stdlib:                     # [linux]
+    - sysroot                 # [linux]
+c_stdlib_version:             # [linux]
+    - '2.28'                  # [linux]


It's set to 2.17 in the feedstock. But I wonder if we need to align here...

antonwolfy · 2026-03-10T11:49:06Z

conda-recipe-cf/conda_build_config.yaml

+cxx_compiler:                 # [win]
+    - vs2022                  # [win]
+c_compiler:                   # [win]
+    - vs2022                  # [win]


As an option we can list all python versions:

Suggested change

- vs2022 # [win]

- vs2022 # [win]

numpy:

- '2'

python:

- 3.10.* *_cpython

- 3.11.* *_cpython

- 3.12.* *_cpython

- 3.13.* *_cp313

- 3.14.* *_cp314

it would mean if we run conda build --no-test -c conda-forge --override-channels conda-recipe-cf command (without numpy and python options passed) and remove strategy matrix from build jobs, each Linux and Windows will build mkl_fft packages with all supported python versions at once.
And then we will be able to remove python-gil from conda-recipe-cf/meta.yaml aligning with the feedstock in more details.

Also, the feedstock adds:

pin_run_as_build: python: min_pin: x.x max_pin: x.x

which we would probably able to do as well.

antonwolfy · 2026-03-10T12:02:54Z

.github/workflows/conda-package-cf.yml

      - name: Store conda paths as envs
        shell: bash -l {0}
        run: |
          echo "CONDA_BLD=$CONDA/conda-bld/win-64/" | tr "\\\\" '/' >> "$GITHUB_ENV"


we should use proper CONDA_BLD value rather then installing conda-build to the base env

Suggested change

echo "CONDA_BLD=$CONDA_PREFIX/conda-bld/win-64/" | tr "\\\\" '/' >> "$GITHUB_ENV"

antonwolfy · 2026-03-10T12:05:48Z

.github/workflows/conda-package.yml

          activate-environment: ${{ env.TEST_ENV_NAME }}
          python-version: ${{ matrix.python }}
-          channels: conda-forge
-          conda-remove-defaults: 'true'


conda-remove-defaults: still used in .github/workflows/build_pip.yaml, but can be removed

ndgrigorian requested review from antonwolfy, jharlow-intel and xaleryb as code owners March 6, 2026 05:31

Copilot AI review requested due to automatic review settings March 6, 2026 05:31

Copilot started reviewing on behalf of ndgrigorian March 6, 2026 05:31 View session

align conda-forge recipe with normal recipe

81591cb

ndgrigorian force-pushed the update-conda-forge-recipe branch from d5aa34a to 81591cb Compare March 6, 2026 05:34

Copilot AI reviewed Mar 6, 2026

View reviewed changes

ndgrigorian and others added 5 commits March 5, 2026 21:51

add conda-build config to conda-forge recipe and update VS

2197063

clean up warnings and errors in windows builds

bc89e74

python_ver -> python

940fe06

Merge branch 'master' into update-conda-forge-recipe

573457b

align conda-forge workflow recipe with feedstock recipe

2bdd772

ndgrigorian force-pushed the update-conda-forge-recipe branch 2 times, most recently from a8ebfdc to 888099b Compare March 9, 2026 21:23

use dedicated build environments in Windows workflow

11b97d9

ndgrigorian force-pushed the update-conda-forge-recipe branch from e07ba98 to 11b97d9 Compare March 9, 2026 21:36

ndgrigorian added 2 commits March 9, 2026 17:06

Merge branch 'master' into update-conda-forge-recipe

39b8b26

Merge branch 'master' into update-conda-forge-recipe

c6c5e80

antonwolfy added this to the 2.2.0 release milestone Mar 10, 2026

antonwolfy reviewed Mar 10, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Align conda-forge recipe with normal recipe#285

Align conda-forge recipe with normal recipe#285
ndgrigorian wants to merge 9 commits intomasterfrom
update-conda-forge-recipe

ndgrigorian commented Mar 6, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 6, 2026

Uh oh!

antonwolfy Mar 10, 2026

Uh oh!

Uh oh!

antonwolfy Mar 10, 2026

Uh oh!

antonwolfy Mar 10, 2026

Uh oh!

antonwolfy Mar 10, 2026

Uh oh!

antonwolfy Mar 10, 2026

Uh oh!

antonwolfy Mar 10, 2026

Uh oh!

antonwolfy Mar 10, 2026

Uh oh!

antonwolfy Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-    - vs2022                  # [win]
+    - vs2022                  # [win]
+numpy:
+    - '2'
+python:
+    - 3.10.* *_cpython
+    - 3.11.* *_cpython
+    - 3.12.* *_cpython
+    - 3.13.* *_cp313
+    - 3.14.* *_cp314


	echo "CONDA_BLD=$CONDA_PREFIX/conda-bld/win-64/" \| tr "\\\\" '/' >> "$GITHUB_ENV"

Conversation

ndgrigorian commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ndgrigorian commented Mar 6, 2026 •

edited

Loading