Skip to content

Remove obsolete LIB/INCLUDE workaround from Windows conda build script - #3013

Open
antonwolfy wants to merge 2 commits into
masterfrom
remove-compiler-w/a-to-dpnp-bld.bat
Open

Remove obsolete LIB/INCLUDE workaround from Windows conda build script#3013
antonwolfy wants to merge 2 commits into
masterfrom
remove-compiler-w/a-to-dpnp-bld.bat

Conversation

@antonwolfy

@antonwolfy antonwolfy commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Removes a stale workaround from conda-recipe/bld.bat that manually prepended BUILD_PREFIX paths onto the Windows LIB and INCLUDE environment variables.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy self-assigned this Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/3013/index.html

@antonwolfy antonwolfy changed the title Remove compiler w/a to include path to the compiler headers Remove obsolete LIB/INCLUDE workaround from Windows conda build script Aug 6, 2026
@antonwolfy antonwolfy added this to the 0.21.0 release milestone Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Array API standard conformance tests for dpnp=0.21.0dev3=py314h509198e_36 ran successfully.
Passed: 1375
Failed: 2
Skipped: 5

@antonwolfy
antonwolfy marked this pull request as ready for review August 6, 2026 12:57
@coveralls

coveralls commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 78.414%. remained the same — remove-compiler-w/a-to-dpnp-bld.bat into master

@ndgrigorian ndgrigorian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants