Skip to content

fix release workflow #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
InftyAI-Agent merged 2 commits into from
Nov 2, 2026
Merged

fix release workflow #143

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54ee717
fix release error
kerthcet Nov 2, 2026
fd94379
remove workflow_dispatch
kerthcet Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,21 @@ name: Release

# Tag-driven: the tag IS the version. Nothing in the repo pins a release version, so a release
# needs no prior bump commit -- the tag is stamped into the images, the binary (VERSION ->
# pkg/version) and dist/install.yaml below. workflow_dispatch exists to re-publish a tag whose
# first run failed halfway, without moving the tag.
# pkg/version) and dist/install.yaml below. Publishing a release from the GitHub UI creates its
# tag, which lands here through the same push trigger -- a `release: published` trigger would
# only start a second, racing run. To retry a failed release, re-run its run: that keeps the
Comment thread
kerthcet marked this conversation as resolved.
Resolved
# tag's commit, where a dispatch would check out the branch it was started from.
on:
push:
tags:
- 'v*'
workflow_dispatch:
inputs:
version:
description: Existing tag to publish
required: true

permissions:
contents: read

env:
CONTROLLER_IMAGE: inftyai/nebula-controller
VERSION: ${{ inputs.version || github.ref_name }}
VERSION: ${{ github.ref_name }}

jobs:
# Both images ship under the same tag. Their names are repeated here rather than taken from env
Expand Down Expand Up @@ -78,12 +75,18 @@ jobs:
- name: Generate install manifest
run: make build-installer IMG=${{ env.CONTROLLER_IMAGE }}:${{ env.VERSION }}

# Runs after the images so a published release never points at a tag nobody can pull.
# Runs after the images so a release this creates never points at a tag nobody can pull.
# One published from the UI, or left by a re-run, already exists: it only gets the
# manifest, and its title, notes and pre-release flag stay as its author set them.
# A pre-release suffix (v0.2.0-rc.1) must not become the repo's "latest" release.
- name: Create release
- name: Publish release
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
if gh release view "$VERSION" >/dev/null 2>&1; then
gh release upload "$VERSION" dist/install.yaml --clobber
exit 0
fi
prerelease=""
case "$VERSION" in *-*) prerelease="--prerelease" ;; esac
gh release create "$VERSION" dist/install.yaml \
Expand Down
Loading