Repository navigation
fix release workflow - #143
Merged
Merged
Conversation
Signed-off-by: kerthcet <kerthcet@gmail.com>
Signed-off-by: kerthcet <kerthcet@gmail.com>
Member
Author
|
/lgtm |
InftyAI-Agent
added
needs-triage
InftyAI-Agent
added
lgtm
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Publishing a release in the GitHub UI does not emit the required tag push event, so removing manual dispatch leaves that release path without image builds, manifest upload, or a run to retry.
1 open issue
What changed in this PR
Updates the tag-driven release workflow to handle existing GitHub releases without overwriting their metadata.
Changes:
- Removes manual dispatch and derives the version directly from the triggering tag.
- Uploads or replaces the install manifest when a release already exists, preserving its title, notes, and pre-release status.
- Updates comments to describe release triggers and retry behavior.
| File | Description |
|---|---|
.github/workflows/release.yml |
Simplifies version selection and adds manifest uploads for existing releases. |
Review effort: Balanced
InftyAI-Agent
approved these changes
Nov 2, 2026
InftyAI-Agent
left a comment
InftyAI-Agent
left a comment
Member
There was a problem hiding this comment.
Approved: PR has both lgtm and approved labels
InftyAI-Agent
approved these changes
Nov 2, 2026
InftyAI-Agent
left a comment
InftyAI-Agent
left a comment
Member
There was a problem hiding this comment.
Approved: PR has both lgtm and approved labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?