Repository navigation
feat(agent-vault): read database and SSH services, and services typed by type - #69
Conversation
|
💬 Discussion in Slack: #pr-review-python-sdk-official-69-feat-agent-vault-read-database-and-ssh-services Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
[Medium impact] The PR appears safe to merge; no new actionable issues were found.
|
scott-ray-wilson
left a comment
There was a problem hiding this comment.
Looks good to me. One low outside the diff: the sessions.create docstring (infisical_sdk/resources/agent_vault.py:349) says an inline service's name is optional, but database and SSH services need one. Without it the API answers 422 at services.0.name.
|
Fixed the |
Infisical's Agent Vault service responses are now typed by
type, and a service can bepostgres,mysqlorsshas well ashttpandmcp. Each type returns only its own fields:http:hostPattern,allowedMethods,allowedPathPrefixes,customHeaders,substitutionsmcp:serverUrl,transport,hostPattern,allowedTools,customHeaderspostgres/mysql:host,port,database,tlsssh:host,porthostPatternwas required onAgentVaultServiceandAgentVaultInlineService, so a bundle with a database or SSH service madeaccess_bundles.get()raiseTypeError. It's optional now, and both models gainhost,port,database,tlsanddescription. Not breaking: every new field defaults toNone.Infisical PR: Infisical/infisical#9235
Node SDK PR: Infisical/node-sdk-v2#49