Skip to content

feat(agent-vault): read database and SSH services, and services typed by type - #69

Merged
saifsmailbox98 merged 4 commits into
mainfrom
saif/age2-297-typed-agent-vault-services
Nov 10, 2026
Merged

saifsmailbox98 merged 4 commits into
mainfrom
saif/age2-297-typed-agent-vault-services

Conversation

@saifsmailbox98

@saifsmailbox98 saifsmailbox98 commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Infisical's Agent Vault service responses are now typed by type, and a service can be postgres, mysql or ssh as well as http and mcp. Each type returns only its own fields:

  • http: hostPattern, allowedMethods, allowedPathPrefixes, customHeaders, substitutions
  • mcp: serverUrl, transport, hostPattern, allowedTools, customHeaders
  • postgres / mysql: host, port, database, tls
  • ssh: host, port

hostPattern was required on AgentVaultService and AgentVaultInlineService, so a bundle with a database or SSH service made access_bundles.get() raise TypeError. It's optional now, and both models gain host, port, database, tls and description. Not breaking: every new field defaults to None.

Infisical PR: Infisical/infisical#9235
Node SDK PR: Infisical/node-sdk-v2#49

@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-python-sdk-official-69-feat-agent-vault-read-database-and-ssh-services

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@linear

linear Bot commented Nov 10, 2026

Copy link
Copy Markdown

AGE2-297

@greptile-apps

greptile-apps Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

[Medium impact] The PR appears safe to merge; no new actionable issues were found.

Summary

Adds database and SSH fields to Agent Vault service responses.

  • Agent Vault responses now carry database and SSH service details.

No new actionable issues found.

Reviews (4) · Last reviewed commit: "docs(agent-vault): say which inline serv..." · Reviewed by Greptile

Comment thread infisical_sdk/api_types.py Resolved

@scott-ray-wilson scott-ray-wilson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One low outside the diff: the sessions.create docstring (infisical_sdk/resources/agent_vault.py:349) says an inline service's name is optional, but database and SSH services need one. Without it the API answers 422 at services.0.name.

@saifsmailbox98

Copy link
Copy Markdown
Member Author

Fixed the sessions.create docstring: the name is optional only for HTTP and MCP services.

@scott-ray-wilson scott-ray-wilson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@saifsmailbox98
saifsmailbox98 merged commit d9e1b5f into main Nov 10, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants