Repository navigation
feat(agent-vault)!: type services by their type, and add database and SSH services - #49
Conversation
|
💬 Discussion in Slack: #pr-review-node-sdk-v2-49-feat-agent-vault-type-services-by-their-type-and-add-da Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
[Medium impact] The PR appears safe to merge; no blocking issues were found.
|
… on the service types that have them
scott-ray-wilson
left a comment
There was a problem hiding this comment.
Looks good to me. One low below, and one outside the diff: the sessions.create JSDoc (src/api/types/agent-vault.ts:868) says an inline service's name is optional, though the database and SSH types already require it.
… say which services need a name
|
Same fix in the |
Infisical's Agent Vault service responses are now typed by
type, and a service can bepostgres,mysqlorsshas well ashttpandmcp. Each type returns only its own fields:http:hostPattern,allowedMethods,allowedPathPrefixes,customHeaders,substitutionsmcp:serverUrl,transport,hostPattern,allowedTools,customHeaderspostgres/mysql:host,port,database,tlsssh:host,portAgentVaultServiceandAgentVaultInlineServicekeep their names and are now unions ontype(AgentVaultHttpService,AgentVaultMcpService,AgentVaultDatabaseService,AgentVaultSshService, and the same for inline services), withAgentVaultServiceTlsfor a database's TLS settings. Both gaindescription.A session's inline services in the response type their
credentialper type too.AgentVaultInlineServiceInputnow also takespostgres,mysqlandsshservices (AgentVaultInlineDatabaseServiceInput,AgentVaultInlineSshServiceInput), and every inline input takesdescription.Breaking for TypeScript callers: reading
hostPattern,serverUrl,transport,customHeadersorsubstitutionsnow needs a check ontypefirst. Nothing changes at runtime.Infisical PR: Infisical/infisical#9235
Python SDK PR: Infisical/python-sdk-official#69