Skip to content

feat(agent-vault)!: type services by their type, and add database and SSH services - #49

Merged
saifsmailbox98 merged 4 commits into
mainfrom
saif/age2-297-typed-agent-vault-services
Nov 10, 2026
Merged

saifsmailbox98 merged 4 commits into
mainfrom
saif/age2-297-typed-agent-vault-services

Conversation

@saifsmailbox98

@saifsmailbox98 saifsmailbox98 commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Infisical's Agent Vault service responses are now typed by type, and a service can be postgres, mysql or ssh as well as http and mcp. Each type returns only its own fields:

  • http: hostPattern, allowedMethods, allowedPathPrefixes, customHeaders, substitutions
  • mcp: serverUrl, transport, hostPattern, allowedTools, customHeaders
  • postgres / mysql: host, port, database, tls
  • ssh: host, port

AgentVaultService and AgentVaultInlineService keep their names and are now unions on type (AgentVaultHttpService, AgentVaultMcpService, AgentVaultDatabaseService, AgentVaultSshService, and the same for inline services), with AgentVaultServiceTls for a database's TLS settings. Both gain description.

A session's inline services in the response type their credential per type too. AgentVaultInlineServiceInput now also takes postgres, mysql and ssh services (AgentVaultInlineDatabaseServiceInput, AgentVaultInlineSshServiceInput), and every inline input takes description.

Breaking for TypeScript callers: reading hostPattern, serverUrl, transport, customHeaders or substitutions now needs a check on type first. Nothing changes at runtime.

Infisical PR: Infisical/infisical#9235
Python SDK PR: Infisical/python-sdk-official#69

@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-node-sdk-v2-49-feat-agent-vault-type-services-by-their-type-and-add-da

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@linear

linear Bot commented Nov 10, 2026

Copy link
Copy Markdown

AGE2-297

@greptile-apps

greptile-apps Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

[Medium impact] The PR appears safe to merge; no blocking issues were found.

Summary

Adds database and SSH service types and makes Agent Vault responses narrowable by type.

  • Agent Vault responses now match service fields to their type.
  • Session inputs can describe database and SSH services.

No actionable new issues or rule violations were found. Tests were not run.

Reviews (3) · Last reviewed commit: "fix(agent-vault): require a username for..." · Reviewed by Greptile

@scott-ray-wilson scott-ray-wilson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One low below, and one outside the diff: the sessions.create JSDoc (src/api/types/agent-vault.ts:868) says an inline service's name is optional, though the database and SSH types already require it.

Comment thread src/api/types/agent-vault.ts Resolved
@saifsmailbox98

Copy link
Copy Markdown
Member Author

Same fix in the sessions.create JSDoc: the name is optional only for HTTP and MCP services.

@scott-ray-wilson scott-ray-wilson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@saifsmailbox98
saifsmailbox98 merged commit 47986f3 into main Nov 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants