Skip to content

feat(agent-vault): require the Agent Vault project with project_id - #68

Merged
saifsmailbox98 merged 4 commits into
mainfrom
saif/age2-177-support-multiple-agent-vault-projects-per-organization
Nov 5, 2026
Merged

saifsmailbox98 merged 4 commits into
mainfrom
saif/age2-177-support-multiple-agent-vault-projects-per-organization

Conversation

@saifsmailbox98

@saifsmailbox98 saifsmailbox98 commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Adds a required project_id to the Agent Vault methods that list or create something in a project, now that an organization can have several Agent Vault projects. Like the CLI, the SDK needs the project named on every one of these calls, so this is a breaking change for Agent Vault callers:

  • proxies.list / proxies.create
  • sessions.list / sessions.create
  • access_bundles.list / access_bundles.create
  • every delegations method, since a delegation is addressed by its machine identity, which can be in several projects

project_id is keyword-only and comes after the existing parameters, so positional arguments keep their places and a call without it raises TypeError before any request.

Lists send it as projectId in the query and creates in the JSON body. Delegations always send it in the query, whatever the method, because that's where the server reads it on those routes. Methods that take a proxy, session or access bundle ID are unchanged: the server reads the project from that.

To send a query string on PUT, POST and DELETE, InfisicalRequests write methods take an optional params.

Infisical PR: Infisical/infisical#9160
CLI PR: Infisical/cli#488
Node SDK PR: Infisical/node-sdk-v2#47

@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-python-sdk-official-68-feat-agent-vault-choose-the-agent-vault-project

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@linear

linear Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

AGE2-177

AGE2-317

@greptile-apps

greptile-apps Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

[Medium impact] The PR appears safe to merge.

Summary

Requires keyword-only project_id for project-scoped Agent Vault calls.

  • Agent Vault calls now name the project they use.

Reviews (4) · Last reviewed commit: "fix(agent-vault): keep the project a cre..." · Reviewed by Greptile

@saifsmailbox98 saifsmailbox98 changed the title feat(agent-vault): choose the Agent Vault project with project_id feat(agent-vault)!: require the Agent Vault project with project_id Nov 5, 2026
@saifsmailbox98 saifsmailbox98 changed the title feat(agent-vault)!: require the Agent Vault project with project_id feat(agent-vault): require the Agent Vault project with project_id Nov 5, 2026

@scott-ray-wilson scott-ray-wilson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the project-level Agent Vault methods from this branch against Infisical/infisical#9160 locally (proxies, access bundles, every delegation method, sessions create, list and revoke), and tests/test_agent_vault.py passes. One small gap: AgentVaultSession and CreatedAgentVaultSession don't include projectId, which the server now returns when a session is created, so it's dropped. The guides in Infisical/infisical#9160 already call project_id=, so this needs to release before or with that PR.

@saifsmailbox98

Copy link
Copy Markdown
Member Author

Added projectId to CreatedAgentVaultSession, so sessions.create keeps it now. This releases together with Infisical/infisical#9160.

@scott-ray-wilson scott-ray-wilson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@saifsmailbox98
saifsmailbox98 merged commit d10a9a9 into main Nov 5, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants