Repository navigation
feat(agent-vault): require the Agent Vault project with projectId - #47
Conversation
|
💬 Discussion in Slack: #pr-review-node-sdk-v2-47-feat-agent-vault-choose-the-agent-vault-project-with-pr Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
[Medium impact] The PR appears safe to merge; no new actionable issue was found.
|
scott-ray-wilson
left a comment
There was a problem hiding this comment.
Ran sink/test-agent-vault.ts from this branch against Infisical/infisical#9160 locally: every step passed, including the delegation methods with projectId in the query. One small gap: the session types don't include projectId, which the server now returns when a session is created, so sessions.create drops it. The docs in Infisical/infisical#9160 already call these parameters, so this needs to release before or with that PR.
|
Added |
Adds a required
projectIdto the Agent Vault methods that list or create something at project level, now that an organization can have several Agent Vault projects. Like the CLI, the SDK needs the project named on every one of these calls, so this is a breaking change for Agent Vault callers:proxies.list/proxies.createsessions.list/sessions.createaccessBundles.list/accessBundles.createdelegationsmethod, since a delegation is addressed by its machine identity, which can be in several projects (the server readsprojectIdfrom the query string on all of them)The list methods no longer default their options, and
delegations.getanddelegations.deletetake{ projectId }as a required second argument, so a call without the project doesn't compile.Lists send it in the query string and creates in the JSON body. Methods addressed by a proxy, session or access bundle ID are unchanged: the server takes the project from that ID.
Infisical PR: Infisical/infisical#9160
CLI PR: Infisical/cli#488
Python SDK PR: Infisical/python-sdk-official#68