Skip to content

feat(agent-vault): require the Agent Vault project with projectId - #47

Merged
saifsmailbox98 merged 6 commits into
mainfrom
saif/age2-177-support-multiple-agent-vault-projects-per-organization
Nov 5, 2026
Merged

saifsmailbox98 merged 6 commits into
mainfrom
saif/age2-177-support-multiple-agent-vault-projects-per-organization

Conversation

@saifsmailbox98

@saifsmailbox98 saifsmailbox98 commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Adds a required projectId to the Agent Vault methods that list or create something at project level, now that an organization can have several Agent Vault projects. Like the CLI, the SDK needs the project named on every one of these calls, so this is a breaking change for Agent Vault callers:

  • proxies.list / proxies.create
  • sessions.list / sessions.create
  • accessBundles.list / accessBundles.create
  • every delegations method, since a delegation is addressed by its machine identity, which can be in several projects (the server reads projectId from the query string on all of them)

The list methods no longer default their options, and delegations.get and delegations.delete take { projectId } as a required second argument, so a call without the project doesn't compile.

Lists send it in the query string and creates in the JSON body. Methods addressed by a proxy, session or access bundle ID are unchanged: the server takes the project from that ID.

Infisical PR: Infisical/infisical#9160
CLI PR: Infisical/cli#488
Python SDK PR: Infisical/python-sdk-official#68

@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-node-sdk-v2-47-feat-agent-vault-choose-the-agent-vault-project-with-pr

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@linear

linear Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

AGE2-177

AGE2-317

@greptile-apps

greptile-apps Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

[Medium impact] The PR appears safe to merge; no new actionable issue was found.

Summary

Requires projectId for project-level Agent Vault calls and every delegation method.

  • Proxy, session, and access-bundle calls now name their project.
  • Delegation calls now name the machine identity's project.

Reviews (5) · Last reviewed commit: "chore: sync the pull request with the br..." · Reviewed by Greptile

@saifsmailbox98 saifsmailbox98 changed the title feat(agent-vault): choose the Agent Vault project with projectId feat(agent-vault)!: require the Agent Vault project with projectId Nov 5, 2026
Comment thread sink/agent-vault.test.ts Resolved
@saifsmailbox98 saifsmailbox98 changed the title feat(agent-vault)!: require the Agent Vault project with projectId feat(agent-vault): require the Agent Vault project with projectId Nov 5, 2026

@scott-ray-wilson scott-ray-wilson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran sink/test-agent-vault.ts from this branch against Infisical/infisical#9160 locally: every step passed, including the delegation methods with projectId in the query. One small gap: the session types don't include projectId, which the server now returns when a session is created, so sessions.create drops it. The docs in Infisical/infisical#9160 already call these parameters, so this needs to release before or with that PR.

@saifsmailbox98

Copy link
Copy Markdown
Member Author

Added projectId to CreatedAgentVaultSession, so sessions.create returns it now. This releases together with Infisical/infisical#9160.

@scott-ray-wilson scott-ray-wilson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@scott-ray-wilson scott-ray-wilson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@saifsmailbox98
saifsmailbox98 merged commit e90bdee into main Nov 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants