Skip to content

Default missing review_rejected to False #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sihrc wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Default missing review_rejected to False #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd46192
Default missing review_rejected to false
sihrc Apr 28, 2026
89bd559
Limit review_rejected default fix to WorkflowResult only
sihrc Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion indico_toolkit/types/workflow_object.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def review_notes(self) -> int:

@property
def review_rejected(self) -> int:
return self.result["review_rejected"]
return self.result.get("review_rejected", False)

@property
def admin_review(self) -> bool:
Expand Down
11 changes: 11 additions & 0 deletions tests/types/test_worflow_result.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,14 @@ def test_classification_predictions():
"model_v1",
)
assert isinstance(wf_result.get_predictions, Classification)


def test_review_rejected_defaults_false_when_missing():
wf_result = WorkflowResult(
{
"submission_id": 12,
"results": {"document": {"results": {"model_v1": {"pre_review": []}}}},
},
"model_v1",
)
assert wf_result.review_rejected is False
Loading