Skip to content

Default missing review_rejected to False#228

Open
sihrc wants to merge 2 commits intomainfrom
fix/review-rejected-default-false
Open

Default missing review_rejected to False#228
sihrc wants to merge 2 commits intomainfrom
fix/review-rejected-default-false

Conversation

@sihrc
Copy link
Copy Markdown
Member

@sihrc sihrc commented Apr 28, 2026

Summary

  • default WorkflowResult.review_rejected to False when key is missing
  • add a targeted regression test for that property behavior

Why

The observed runtime error is from strict access in workflow_object.py when payloads omit review_rejected.

Testing

  • Added test:
    • tests/types/test_worflow_result.py
  • Local execution note: unable to run pytest in this environment due to missing indico dependency (ModuleNotFoundError: No module named 'indico').

Note

Low Risk
Small defensive change to result parsing plus a unit test; minimal behavioral impact beyond avoiding errors on missing fields.

Overview
WorkflowResult.review_rejected now defaults to False when review_rejected is missing from the result payload instead of raising on strict key access.

Adds a regression test ensuring omitted review_rejected is treated as not rejected.

Reviewed by Cursor Bugbot for commit 89bd559. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant