Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkflowResult.review_rejectedtoFalsewhen key is missingWhy
The observed runtime error is from strict access in
workflow_object.pywhen payloads omitreview_rejected.Testing
tests/types/test_worflow_result.pyindicodependency (ModuleNotFoundError: No module named 'indico').Note
Low Risk
Small defensive change to result parsing plus a unit test; minimal behavioral impact beyond avoiding errors on missing fields.
Overview
WorkflowResult.review_rejectednow defaults toFalsewhenreview_rejectedis missing from the result payload instead of raising on strict key access.Adds a regression test ensuring omitted
review_rejectedis treated as not rejected.Reviewed by Cursor Bugbot for commit 89bd559. Bugbot is set up for automated code reviews on this repo. Configure here.