chore: update review state with new findings and issue deduplication#32
Open
BodenMcHale wants to merge 3 commits into
Open
chore: update review state with new findings and issue deduplication#32BodenMcHale wants to merge 3 commits into
BodenMcHale wants to merge 3 commits into
Conversation
Top finding (score 8.10, carry forward): 4 failing tests in test/analyzer.test.ts introduced by PR #2 merge — branch owl-alpha/add-tests-and-timeout was forked before 8d29a8c tightened Permissions-Policy scoring. GitHub MCP re-authorization was required; deduplication and issue creation blocked. Findings preserved in runner_ups. https://claude.ai/code/session_01CzHFbZqhKAXfPaFZEFiyCY
Filed #21: CSP 'unsafe-inline' penalized when 'strict-dynamic' + nonce present — false positive against recommended Google Strict CSP pattern. Score 7.10. Runner-ups: #15 (4 failing tests, score 8.1), #7 (HEAD fetch, 8.1), #5 (base-uri, 7.9), #17 (HSTS max-age=0, 7.0), #19 (form-action, 6.8), #16 (CSP wildcard, 6.1), #20 (CSP-Report-Only, 5.9) — all duplicates. https://claude.ai/code/session_01CzHFbZqhKAXfPaFZEFiyCY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the code review state tracking file to reflect the latest automated security review run, including new findings filed as issues and deduplication of runner-up findings against existing open/closed issues.
Key Changes
'unsafe-inline'penalized even when'strict-dynamic'+ nonce is present — false positive flags a recommended strict CSP pattern #21: CSP'unsafe-inline'penalty false positive when'strict-dynamic'+ nonce is present — a recommended backwards-compatibility pattern that is safely ignored by CSP3 browsers (score: 7.10)no-referrer-when-downgradeclassified as "strong" — awards full score for the historical browser default that leaks full URLs cross-origin #18, [REVIEW] CSP: missingform-actiondirective not flagged —default-src 'self'leaves form submissions unrestricted #19, [REVIEW] CSP: Content-Security-Policy-Report-Only is invisible to the analyzer — report-only deployments score 0/30 as if no CSP exists #20) and 1 to closed issue [REVIEW] CSP: checkCSP awards full score without verifying base-uri restriction, enabling silent <base> injection bypass #5test/analyzer.test.tsdue to branch divergence before Permissions-Policy scoring tightening (score: 8.1, duplicate of [REVIEW] Permissions-Policy tests: 4 assertions broken by merge regression — main branch CI is red #15)form-actiondirective not flagged —default-src 'self'leaves form submissions unrestricted #19)src/index.tsexports,src/analyzer.tsgrade thresholds, andsrc/fetch.tstimeout implementationNotable Details
'unsafe-inline'+'strict-dynamic'+ nonce pattern is a legitimate backwards-compatibility approach per CSP3 spec and should not be penalizedhttps://claude.ai/code/session_01CzHFbZqhKAXfPaFZEFiyCY